Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logs table migration: skip on corrupted json and fail later #1856

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 12, 2023

enhance #1828

@6543 6543 added enhancement improve existing features skip-changelog server labels Jun 12, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 45.45% and no project coverage change.

Comparison is base (ff01a9f) 39.25% compared to head (02da810) 39.26%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1856   +/-   ##
=======================================
  Coverage   39.25%   39.26%           
=======================================
  Files         173      173           
  Lines       10625    10633    +8     
=======================================
+ Hits         4171     4175    +4     
- Misses       6174     6177    +3     
- Partials      280      281    +1     
Impacted Files Coverage Δ
.../store/datastore/migration/019_alter_logs_table.go 54.44% <45.45%> (-0.44%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@6543 6543 requested a review from a team June 13, 2023 02:20
@lafriks lafriks merged commit 6be61e6 into woodpecker-ci:master Jun 13, 2023
@6543 6543 deleted the respect_json_errors branch June 13, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants