Do not store inactive repos without any resources

[qwerty287]

Do not sync repos with forge if the repo is not necessary in DB.

In the DB, only repos that were active once or repos that are currently active are stored. When trying to enable new repos, the repos list is fetched from the forge instead and displayed directly. In addition to this, the forge func Perm was removed and is now merged with Repo.

Solves a TODO on RepoBatch.

[anbraten]

Does this fix / help with #485?

How are repo permission now handled? From a first look you check if a user is having and update access on create / activate / re-activate, repair, move and in the repo-middleware if the last sync was 1 hour ago?

[qwerty287]

Does this fix / help with #485?

I think yes, at least partially.

How are repo permission now handled? From a first look you check if a user is having and update access on create / activate / re-activate, repair, move and in the repo-middleware if the last sync was 1 hour ago?

Yes, I think that's correct. Didn't change much from before though.

[qwerty287]

As for #485, this definitely prepares it. I think I can create a new PR that closes it after this one because this is out of scope for this one.

This is actually more similar to it than I originally thought. I'm working on partially fixing it.

[qwerty287]

OK, I removed support for flat permissions as it was completely unused in 4e16b8f. This also was the first task from #485. The second one is not related to this PR and should be done separately.

[6543]

Does this fix / help with #485?

did not had a deeper look into it ... but if we only request permissions on demand (by having a paginated view on the repo activation page ...)

[6543]

i would expizite check against errorNotFound

[qwerty287]

That should be done below

[6543]

hmm well it's not the usual code-style but you are right

[6543]

diff --git a/server/api/repo.go b/server/api/repo.go
index 64db2f80..da7eccf7 100644
--- a/server/api/repo.go
+++ b/server/api/repo.go
@@ -42,14 +42,19 @@ func PostRepo(c *gin.Context) {
 
        owner := c.Param("owner")
        name := c.Param("name")
+       enabledOnce := false
        repo, err := _store.GetRepoName(owner + "/" + name)
-       enabledOnce := err == nil // if there's no error, the repo was found and enabled once already
+       if err != nil {
+               if !errors.Is(err, types.RecordNotExist) {
+                       // we got an unexpected error
+                       _ = c.AbortWithError(http.StatusInternalServerError, err)
+                       return
+               }
+               enabledOnce = true
+       }
        if enabledOnce && repo.IsActive {
                c.String(http.StatusConflict, "Repository is already active.")
                return
-       } else if err != nil && !errors.Is(err, types.RecordNotExist) {
-               c.String(http.StatusInternalServerError, err.Error())
-               return
        }

not sure if it's worth changing it to that or not