Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Docker credential helpers #1075

Merged
merged 5 commits into from
Aug 14, 2022

Conversation

qwerty287
Copy link
Contributor

Replaces #857. Removes the ecr package and adds some docs about it instead.

@qwerty287 qwerty287 requested a review from a team August 4, 2022 07:23
@qwerty287 qwerty287 added enhancement improve existing features backend/docker labels Aug 4, 2022
@qwerty287 qwerty287 changed the title Support Docker credentials Support Docker credential helpers Aug 4, 2022
@qwerty287 qwerty287 added this to the 1.0.0 milestone Aug 4, 2022
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Aug 4, 2022

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-1075.surge.sh

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #1075 (b7957c5) into master (b7957c5) will not change coverage.
The diff coverage is n/a.

❗ Current head b7957c5 differs from pull request most recent head 73edb8f. Consider uploading reports for the commit 73edb8f to get more accurate results

@@           Coverage Diff           @@
##           master    #1075   +/-   ##
=======================================
  Coverage   50.51%   50.51%           
=======================================
  Files          82       82           
  Lines        6270     6270           
=======================================
  Hits         3167     3167           
  Misses       2920     2920           
  Partials      183      183           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anbraten anbraten added the documentation docu & docs label Aug 14, 2022
@anbraten anbraten enabled auto-merge (squash) August 14, 2022 08:14
@anbraten anbraten merged commit bed3ef1 into woodpecker-ci:master Aug 14, 2022
@qwerty287 qwerty287 deleted the docker-creds branch August 16, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend/docker documentation docu & docs enhancement improve existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants