Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build proc list to be returned always in correct order #1060

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Jul 31, 2022

Currently processes can be returned in incorrect order depending on how database returns them that could be random and even changing order

@qwerty287 qwerty287 enabled auto-merge (squash) August 2, 2022 16:02
@qwerty287 qwerty287 merged commit 550aefe into woodpecker-ci:master Aug 2, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1060 (fa6c900) into master (7031904) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1060      +/-   ##
==========================================
+ Coverage   50.55%   50.58%   +0.02%     
==========================================
  Files          82       82              
  Lines        6268     6271       +3     
==========================================
+ Hits         3169     3172       +3     
  Misses       2916     2916              
  Partials      183      183              
Impacted Files Coverage Δ
server/store/datastore/proc.go 64.40% <100.00%> (+1.90%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@lafriks lafriks deleted the fix/proc_list_order branch August 2, 2022 16:45
@6543 6543 added enhancement improve existing features backport indicates that this pull needs/has a backport bug Something isn't working and removed enhancement improve existing features labels Aug 2, 2022
@6543 6543 added this to the 1.0.0 milestone Aug 2, 2022
@6543
Copy link
Member

6543 commented Aug 2, 2022

please backport :)

@lafriks
Copy link
Contributor Author

lafriks commented Aug 2, 2022

@6543 done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport indicates that this pull needs/has a backport bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants