Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use UUID for Steps #983

Closed
6543 opened this issue Jun 16, 2022 · 8 comments · Fixed by #1802
Closed

Use UUID for Steps #983

6543 opened this issue Jun 16, 2022 · 8 comments · Fixed by #1802
Labels
agent backend/docker enhancement improve existing features
Milestone
1.0.0

Comments

@6543
Copy link
Member

6543 commented Jun 16, 2022

9449b67 do show that we should not rely on a name to identify containers

(https://ci.woodpecker-ci.org/woodpecker-ci/woodpecker/build/2736/8)
-> Error response from daemon: Conflict. The container name "/pipeline.build-web" is already in use by container "8b762354d71226969e0b4f87f5244b93c0d0c092fd004362b5d71def5fd63ddc". You have to remove (or rename) that container to be able to reuse that name.
@6543 6543 added agent enhancement improve existing features backend/docker labels Jun 16, 2022
@6543
Copy link
Member Author

6543 commented Jun 16, 2022

cc @LamaAni

@6543 6543 added this to the 1.0.0 milestone Jun 16, 2022
@LamaAni
Copy link
Contributor

LamaAni commented Jun 17, 2022

Hi

Agreed on this. There is an issue also with improper conversion to spaces. e.g. If the name is "A B". A fix will come once I get a moment. I plan some bug fixes session soon.

Best
LamaAni

@LamaAni
Copy link
Contributor

LamaAni commented Jun 17, 2022

The new name will be to_kube_valid(name+'-'s'+[step index])

@LamaAni
Copy link
Contributor

LamaAni commented Jun 17, 2022

Hum. I dont see the same issue in kubectl... The Specific random run_id I add there resolves this issue. Did you run this in docker?

@6543
Copy link
Member Author

6543 commented Jun 20, 2022

yes

@6543
Copy link
Member Author

6543 commented Jun 20, 2022

I think the run_id is not within the docker backend ...

@LamaAni
Copy link
Contributor

LamaAni commented Jun 21, 2022

Hi, The run_id is not within it. That is way I needed the random number on my executor.

Which branch lead to the error in the run_id? Did you check if this exists on the original docker backed? I would assume so.

@anbraten anbraten mentioned this issue Sep 29, 2022
Closed
@6543 6543 mentioned this issue Jun 4, 2023
Merged
14 tasks
@6543
Copy link
Member Author

6543 commented Jun 4, 2023

-> #1802

@6543 6543 changed the title Use UUID for proc names Use UUID for Steps Jun 4, 2023
@6543 6543 closed this as completed in #1802 Jun 6, 2023
@6543 6543 closed this as completed in 556607b Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent backend/docker enhancement improve existing features
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Rework log streaming and related functions anbraten/woodpecker
2 participants
@LamaAni @6543