-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent service name to be equal to step name #557
Comments
Issue detected: Service name is not allowed to be equal to one step name. |
instead of preventing it we should fix the underling bug |
// add services steps
if len(conf.Services.Containers) != 0 {
stage := new(backend.Stage)
stage.Name = fmt.Sprintf("%s_services", c.prefix)
stage.Alias = "services"
for i, container := range conf.Services.Containers {
if !container.Constraints.Match(c.metadata) {
continue
}
+ name := fmt.Sprintf("%s_services_%d", c.prefix, i)
step := c.createProcess(name, container, "services")
stage.Steps = append(stage.Steps, step)
}
config.Stages = append(config.Stages, stage)
} Hmm, the compiler should not be the problem. |
without looking at the code, i guess it's an issue with the gRPC api |
https://github.com/woodpecker-ci/woodpecker/blob/master/pipeline/rpc/proto/woodpecker.proto#L92-L95 look's like the name is actually used as ID for gRPC - we just have to change that EDIT: no ProcID is used - so the conflict should not come from agent |
linking #983 |
-> #1802 |
postgres and mysql jobs are skipped somehow
The text was updated successfully, but these errors were encountered: