Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't deactivate PR CI runs #3257

Closed
2 of 3 tasks
HerHde opened this issue Jan 22, 2024 · 1 comment · Fixed by #3258
Closed
2 of 3 tasks

Can't deactivate PR CI runs #3257

HerHde opened this issue Jan 22, 2024 · 1 comment · Fixed by #3258
Labels
bug Something isn't working
Milestone

Comments

@HerHde
Copy link
Contributor

HerHde commented Jan 22, 2024

Component

server, web-ui

Describe the bug

It seems to me that I can't deactivate CI runs for PRs, although the project setting Allow Pull Requests is disabled:

image

image

I have the impression that this problem just came up a few versions ago.

System Info

{"source":"https://github.com/woodpecker-ci/woodpecker","version":"2.1.1"}
AND
{"source":"https://github.com/woodpecker-ci/woodpecker","version":"2.2.2"}

Additional context

When I update the settings, "allow_pr":false is send and updated in the PUT request, but "pr_enabled":false, which is returned in the response, is untouched. Don't know if this has to do with it, but it sounds quite similar.

I didn't checked the next version, but had to confirm it. However, nothing mentioned in the issues afaics.

Validations

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
@HerHde HerHde added the bug Something isn't working label Jan 22, 2024
@HerHde
Copy link
Contributor Author

HerHde commented Jan 22, 2024

If I'm misinterpreting what I'm seeing I'd like to propose to add a title element to the icons next to master etc. ;-)

@qwerty287 qwerty287 added this to the 2.3.0 milestone Jan 22, 2024
lafriks pushed a commit that referenced this issue Jan 22, 2024
fernandrone pushed a commit to quintoandar/woodpecker that referenced this issue Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants