Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include prebuild webui in source tarbal #3219

Closed
6543 opened this issue Jan 19, 2024 · 3 comments · Fixed by #3244
Closed

include prebuild webui in source tarbal #3219

6543 opened this issue Jan 19, 2024 · 3 comments · Fixed by #3244
Labels
build CI pipeline related

Comments

@6543
Copy link
Member

6543 commented Jan 19, 2024

this way packages like alpine and nix dont have problems to build woodpecker.

as they neither have to worry about rollup's mess with native binarys nor that pnpm builttools are not jet in place in nix
@6543 6543 added the build CI pipeline related label Jan 19, 2024
@qwerty287
Copy link
Contributor

This will be hard to do with pnpm. We had this issue before in #1262

@qwerty287
Copy link
Contributor

Or do you just mean the compiled webui? This should work.

@6543
Copy link
Member Author

6543 commented Jan 19, 2024

yes compile the webui ;)

This was referenced Jan 19, 2024
Closed
Merged
6543 added a commit to 6543-forks/woodpecker that referenced this issue Jan 21, 2024
@6543
Build tarball for distribution packages
d0ec41c 
address woodpecker-ci#3219
@6543 6543 mentioned this issue Jan 21, 2024
Merged
lafriks pushed a commit that referenced this issue Jan 21, 2024
@6543
Build tarball for distribution packages (#3244)
9e862ae 
close  #3219

and also make sure the `binaries` & `docker` workflow will run on tag
events, see https://ci.woodpecker-ci.org/repos/3780/pipeline/12358
fernandrone pushed a commit to quintoandar/woodpecker that referenced this issue Feb 1, 2024
@6543 @fernandrone
Build tarball for distribution packages (woodpecker-ci#3244)
686045c 
close  woodpecker-ci#3219

and also make sure the `binaries` & `docker` workflow will run on tag
events, see https://ci.woodpecker-ci.org/repos/3780/pipeline/12358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build CI pipeline related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build tarball for distribution packages 6543-forks/woodpecker
2 participants
@6543 @qwerty287