Skip to content

Commit

Permalink
Adjust github scopes and clarify documentation. (#2578)
Browse files Browse the repository at this point in the history
Add scopes needed when creating Github application.
Removed "repo:status" scope, because it is included in already requested
"repo" scope.

Fixes: #1081
  • Loading branch information
OskarsPakers authored Oct 14, 2023
1 parent 55766ea commit afef609
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ services:

## Registration

Register your application with GitHub to create your client id and secret. It is very important that the authorization callback URL matches your http(s) scheme and hostname exactly with `<scheme>://<host>/authorize` as the path.
Register your application with GitHub to create your client id and secret. Grant "repo", "user:email" and "read:org" scopes. It is very important that the authorization callback URL matches your http(s) scheme and hostname exactly with `<scheme>://<host>/authorize` as the path.

Please use this screenshot for reference:

Expand Down
2 changes: 1 addition & 1 deletion server/forge/github/github.go
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ func (c *client) newConfig(req *http.Request) *oauth2.Config {
return &oauth2.Config{
ClientID: c.Client,
ClientSecret: c.Secret,
Scopes: []string{"repo", "repo:status", "user:email", "read:org"},
Scopes: []string{"repo", "user:email", "read:org"},
Endpoint: oauth2.Endpoint{
AuthURL: fmt.Sprintf("%s/login/oauth/authorize", c.url),
TokenURL: fmt.Sprintf("%s/login/oauth/access_token", c.url),
Expand Down

0 comments on commit afef609

Please sign in to comment.