Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov binary download: follow links #13

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Fix codecov binary download: follow links #13

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e709c8
follow links
pat-s Oct 24, 2023
865f595
alpine
pat-s Oct 24, 2023
52ef8ef
Update Dockerfile
pat-s Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ COPY . .
#
RUN apk add -q --no-cache ca-certificates curl
RUN go build -ldflags '-s -w -extldflags "-static"' -o plugin-codecov
RUN if [ $(arch) = "aarch64" ] ; then curl -s https://github.com/codecov/uploader/releases/download/${UPLOADER_VERSION}/codecov-aarch64 -o codecov; fi
RUN if [ $(arch) = "x86_64" ] ; then curl -s https://github.com/codecov/uploader/releases/download/${UPLOADER_VERSION}/codecov-alpine -o codecov; fi
RUN if [ $(arch) = "aarch64" ] ; then curl -sL https://github.com/codecov/uploader/releases/download/${UPLOADER_VERSION}/codecov-aarch64 -o codecov; fi
pat-s marked this conversation as resolved.
Show resolved Hide resolved
RUN if [ $(arch) = "x86_64" ] ; then curl -sL https://github.com/codecov/uploader/releases/download/${UPLOADER_VERSION}/codecov-alpine -o codecov; fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RUN if [ $(arch) = "x86_64" ] ; then curl -sL https://github.com/codecov/uploader/releases/download/${UPLOADER_VERSION}/codecov-alpine -o codecov; fi
RUN if [ $(arch) = "x86_64" ] ; then curl -sLf https://github.com/codecov/uploader/releases/download/${UPLOADER_VERSION}/codecov-alpine -o codecov; fi

RUN chmod +x codecov plugin-codecov

FROM scratch
Expand Down