Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug with CES modal styles after breaking change in GB radio component. #35628

Closed
wants to merge 2 commits into from

Conversation

joelclimbsthings
Copy link
Contributor

@joelclimbsthings joelclimbsthings commented Nov 17, 2022

All Submissions:

Changes proposed in this Pull Request:

This is to resolve a styling issue on the CES modal that cropped up in stores running WP 6.1:

image

It looks like this was due to a breaking change in the GB RadioControl component within this PR. In effect users that are running on top of WP 6.0 had no issue, while those with 6.1 saw the above vertical layout within the CES modal.

I've added styles to address the change, and currently I've left the previous styles intact to ensure we don't have the same issue crop on on 6.0 and earlier installations. Ideally these should eventually be removed.

We could also potentially target both successfully with the :has selector, , but that is not supported in Firefox currently.

Closes #35570 .

How to test the changes in this Pull Request:

  1. Checkout branch on new store running WP 6.1
  2. Ensure you enable event tracking when asked.
  3. Create your first product, and then click "Give feedback" on the popup after publishing.
  4. Observe that the modal layout is correct:

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added the package: @woocommerce/customer-effort-score issues related to @woocommerce/customer-effort-score label Nov 17, 2022
@joelclimbsthings joelclimbsthings requested a review from a team November 17, 2022 22:54
@joelclimbsthings joelclimbsthings self-assigned this Nov 17, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2022

Test Results Summary

Commit SHA: fca08ec

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26000202620m 55s
E2E Tests186006019215m 43s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@joshuatf joshuatf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this up, Joel! This is testing well for me and fixes the issue on larger screens.

I left a comment about smaller screens, but not entirely sure what that was supposed to look like before so pre-approving, but happy to review again if we need to update that. cc @jarekmorawski

@@ -3,6 +3,15 @@
.woocommerce-customer-effort-score__selection {
margin: 1em 0;

.components-v-stack {
display: flex;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On smaller screens, this still looks a little odd, but I'm not really sure what it was supposed to look like before:

Screen Shot 2022-11-18 at 5 34 39 AM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny, I thought the same and tried centering everything, but it still looked odd. I'll look more into this, but feedback from @jarekmorawski would be helpful.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we break it into two columns and center them? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that on smaller screens it looks odd, but it is readable and useable. Since this is a code freeze exception, I suggest we merge this fix as is and tackle further improvements for small viewports in the future.

Copy link
Contributor Author

@joelclimbsthings joelclimbsthings Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually ended up favoring @louwie17 's fix which had the icons centered, so this one will be closed. As Matt suggested any further improvements can be captured in another issue.

@kalessil kalessil deleted the fix/35570 branch September 25, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: @woocommerce/customer-effort-score issues related to @woocommerce/customer-effort-score
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customer effort score modal not working properly
4 participants