-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing bug with CES modal styles after breaking change in GB radio component. #35628
Conversation
Test Results SummaryCommit SHA: fca08ec
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this up, Joel! This is testing well for me and fixes the issue on larger screens.
I left a comment about smaller screens, but not entirely sure what that was supposed to look like before so pre-approving, but happy to review again if we need to update that. cc @jarekmorawski
@@ -3,6 +3,15 @@ | |||
.woocommerce-customer-effort-score__selection { | |||
margin: 1em 0; | |||
|
|||
.components-v-stack { | |||
display: flex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funny, I thought the same and tried centering everything, but it still looked odd. I'll look more into this, but feedback from @jarekmorawski would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we break it into two columns and center them? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that on smaller screens it looks odd, but it is readable and useable. Since this is a code freeze exception, I suggest we merge this fix as is and tackle further improvements for small viewports in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually ended up favoring @louwie17 's fix which had the icons centered, so this one will be closed. As Matt suggested any further improvements can be captured in another issue.
All Submissions:
Changes proposed in this Pull Request:
This is to resolve a styling issue on the CES modal that cropped up in stores running WP 6.1:
It looks like this was due to a breaking change in the GB RadioControl component within this PR. In effect users that are running on top of WP 6.0 had no issue, while those with 6.1 saw the above vertical layout within the CES modal.
I've added styles to address the change, and currently I've left the previous styles intact to ensure we don't have the same issue crop on on 6.0 and earlier installations. Ideally these should eventually be removed.
We could also potentially target both successfully with the
:has
selector, , but that is not supported in Firefox currently.Closes #35570 .
How to test the changes in this Pull Request:
Other information:
pnpm --filter=<project> changelog add
?FOR PR REVIEWER ONLY: