This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add storybook demo for CheckboxControl #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
nerrad
added
tools
opr
changed the title
|
@opr is this ready for review? I see the diff is quite big (+28k, -19k) and I'm not sure what files need to be reviewed, any clues? I think maybe undoing the merge and instead rebasing this branch with trunk would simplify the diff? Otherwise, what about cherry picking the relevant commits into a new branch based on trunk? I'm a bit wary of merging a PR as big as this one, specially considering github-actions reports some assets increase. |
opr
force-pushed
the
add/checkbox-story
branch
from
8754658
to
503776d
Compare
|
Size Change: 0 B Total Size: 1.17 MB ℹ️ View Unchanged
|
Aljullu
approved these changes
Dec 10, 2020
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import Component from '../'; |
There was a problem hiding this comment.
It seems like in other stories we are importing the components with their name (in this case, it would be CheckboxControl), and the story has a generic name (in some that I checked, it was named Default). Do you think we should keep it consistent here?
There was a problem hiding this comment.
Yes I agree! I'll make this change
This keeps our stories more consistent
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3031
Accessibility
All animations respectprefers-reduced-motionScreenshots
How to test the changes in this Pull Request:
npm run storybook@base-components>CheckboxControl>CheckboxControl