Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting product when variation has no attributes #372

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Fix formatting product when variation has no attributes #372

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec9848a
Fix formatting product when variation has no attributes
tomalec Mar 7, 2024
9e09435
Simplify the check for product variation,
tomalec Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion includes/class-wc-abstract-google-analytics-js.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ function ( $item ) {
*
* @param WC_Product $product The product to format.
* @param array|bool $variation An array containing product variation attributes to include in the product data.
* For the "variation" type products, we'll use product->get_attributes.
*
* @return array
*/
Expand All @@ -230,7 +231,7 @@ public function get_formatted_product( WC_Product $product, $variation = false )
$variation = $product->get_attributes();
}

if ( false !== $variation ) {
if ( is_array( $variation ) ) {
$formatted['variation'] = implode(
', ',
array_map(
Expand Down
Loading