-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Node.js 18 and bump all NPM dev dependencies #345
Conversation
"node": ">=12", | ||
"npm": ">=6" | ||
"node": ">=18", | ||
"npm": ">=9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node v16 is still compatible and gives 0 issues as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer to #345 (comment).
Hi @eason9487 Thanks for the work done, however I see Node v16 is still compatible so I wonder if we should allow that version in the engines. |
Hi @puntope, thanks for the review.
Node.js v16 has exceeded its end-of-life date, 11 Sep 2023, so there should be no need to keep v16. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM
Thanks @eason9487 for clarifying the npm v16 topic. This can be merged
Changes proposed in this Pull Request:
Closes #281
Checks:
Detailed test instructions:
npm install
to see if it can finish without errors.npm audit
to check if it reports 0 vulnerabilities.npm start
,npm run dev
,npm run build
, andnpm run lint:js
work well.quantity
value for checkout event tracking #343 to determine if the event tracking is sent with Checkout block.Changelog entry