This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product Image: use WC Core function to render image #9984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +4 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
woocommercebot
requested review from
a team and
thealexandrelara
and removed request for
a team
dinhtungdu
added
type: bug
There was a problem hiding this comment.
Hey @dinhtungdu,
Thank you for working on this! I was testing and it is working as expected. I just want to confirm with you regarding the step 3 of the testing steps
- See
elements have loading, srcset, size attributes.
I can see the alt and src attributes, but size and loading is not showing to me. Am I missing something?
|
@thealexandrelara Maybe it's a cache issue. Can you rebuild the branch and test again? Here is what I have on my end: |
thealexandrelara
approved these changes
Jun 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the image render function of the Product Image block to use WC Core functions.
Fixes #9979
Testing
Automated Tests
User Facing Testing
<img>elements haveloading,srcset,sizeattributes.WooCommerce Visibility
Performance Impact
N/a
Changelog