Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Release: 9.1.1 #7948

Merged
merged 25 commits into from
Dec 15, 2022
Merged

Release: 9.1.1 #7948

merged 25 commits into from
Dec 15, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 14, 2022

Patch release

This is the patch release pull request for WooCommerce Blocks plugin 9.1.1.

Changelog


#### Enhancements

- Products block: Add patterns. ([7857](https://github.com/woocommerce/woocommerce-blocks/pull/7857))
- Filter by Stock: Add dropdown version.
- Filter by Stock: Add option to choose multiple or single option. ([7831](https://github.com/woocommerce/woocommerce-blocks/pull/7831))
- Filter by Rating: Add dropdown version.
- Filter by Rating: Add option to choose multiple or single option.
- Filters: Fix the little gaps on the border corners in the filters Dropdown version. ([7771](https://github.com/woocommerce/woocommerce-blocks/pull/7771))
- Product Query - Enable "Inherit Query from template" option. ([7641](https://github.com/woocommerce/woocommerce-blocks/pull/7641))

#### Bug Fixes

- Classic Products Template and Products: Improve the layout of the Rating. ([7932](https://github.com/woocommerce/woocommerce-blocks/pull/7932))
- Product Elements: Fix misc block settings for Product Button, Price and Rating. ([7914](https://github.com/woocommerce/woocommerce-blocks/pull/7914))
- Fix Padding, Margin, Border Width, and Radius settings for all relevant blocks. ([7909](https://github.com/woocommerce/woocommerce-blocks/pull/7909))
- Fix wrong Mini Cart amount displayed when displaying prices including taxes. ([7832](https://github.com/woocommerce/woocommerce-blocks/pull/7832))
- Product Query: Add Sorted by title preset to Popular Filters. ([7949])(https://github.com/woocommerce/woocommerce-blocks/pull/7949))


Communication

Prepared Updates

Please leave a comment on this PR with links to the following:

  • Release announcement (announcement post on developer.woocommerce.com published after release).

  • Happiness engineering or Happiness/Support (if special instructions needed).

  • Relevant developer documentation (if applicable).

Quality

This section is for things related to quality around the release.

  • Testing Instructions are included in this PR

  • Any performance impacts are documented.


🚀 This pull request was generated by the automations bot triggered by the creation of the branch: release/9.1.1. cc @danieldudzic

@github-actions
Copy link
Contributor Author

github-actions bot commented Dec 14, 2022

Patch release steps

The release pull request has been created! This checklist is a guide to follow for the remainder of the patch release process. You can check off each item in this list once completed.

  • Checkout the release branch locally.

Initial Preparation

  • Close the milestone of the release you are going to ship. That will prevent newly approved PRs to be automatically assigned to that milestone.
  • Check that the release automation correctly added the changelog to readme.txt
  • Ensure you pull your changes from the remote, since GitHub Actions will have added new commits to the branch.
    • Check the version and date in the changelog section within readme.txt, e.g. = 9.1.1 - YYYY-MM-DD =
    • Check the changelog matches the one in the pull request description above.
  • Update compatibility sections (if applicable). Note: Do not change the stable tag or plugin version; this is automated.
  • Push above changes to the release branch.

Create the Testing Notes

  • Run npm ci
  • Run npm run package-plugin:deploy. This will create a zip of the current branch build locally.
  • Create the testing notes for the release.
    • For each pull request that belongs to the current release, grab the User Facing Testing notes from the PR's description. Be sure that the Do not include in the Testing Notes is not flagged checkbox is unchecked.
    • Add the notes to docs/internal-developers/testing/releases
    • Update the docs/internal-developers/testing/releases/README.md file index.
  • Copy a link to the release zip you created earlier into the testing notes. To generate the link you can upload the zip as an attachment in a GitHub comment and then just copy the path (without publishing the comment).
  • Commit and push the testing docs to the release branch.
  • Smoke test built release zip using the testing instructions you created:
    • Test in a clean environment, e.g. Jurassic.Ninja site.
    • Test existing WooCommerce Blocks content works correctly after update (no block validation errors).
    • Test to confirm blocks are available and work correctly in oldest supported WordPress version (e.g. 5.3).
    • Confidence check - check blocks are available and function.
    • Test to confirm new features/fixes are working correctly.
    • Test any UI changes in mobile and desktop views.
    • Smoke test – test a cross section of core functionality.
  • Ask the porters of Rubik and Kirigami to smoke test the built release zip as well and to approve the PR if everything looks good.

Each porter is responsible for testing the PRs that fall under the focus of their own team. Shared functionality should be tested by both porters. This means that the Rubik porter will mostly test checkout blocks and Store API endpoints, while the Kirigami porter will test the product related blocks and Store API endpoints.

  • If all PRs are testing as expected, continue with the release.
  • If one or more PRs are not testing as expected: ping the PR authors and the porter of the relevant team and ask them if the change is a release blocker or not (you can also ping the team lead if any of them is not available). In general, if it's not a regression or there is no product/marketing reason why that PR is a blocker, all other PRs should default to not being blockers.
    • If there are blockers: stop the release and ask the PR author to fix them. If the PR author is AFK, ping the porter of their team.
    • If some PRs are not testing as expected but they are not blockers: revert the relevant commits, remove the changes from testing steps and changelog, open an issue (or reopen the original one) and proceed with the release.
    • If minor issues are discovered during the testing, each team is responsible for logging them in Github.

Update Pull Request description and get approvals

  • Go through the description of the release pull request and edit it to update all the sections and checklist instructions there.
  • Execute npm run deploy
    • Note: the script automatically updates version numbers (commits on your behalf).
    • ALERT: This script will ask you if this release will be deployed to WordPress.org. You should only answer yes for this release if it's the latest release and you want to deploy to WordPress.org. Otherwise, answer no. If you answer yes, you will get asked additional verification by the npm run deploy script about deploying a patch release to WordPress.org.

If this release is deployed to WordPress.org

  • An email confirmation is required before the new version will be released, so check your email in order to confirm the release.
  • Edit the GitHub release and copy changelog into the release notes.
  • The #woo-blocks-repo slack instance will be notified about the progress with the WordPress.org deploy. Watch for that. If anything goes wrong, an error will be reported and you can followup via the GitHub actions tab and the log for that workflow.
  • After the wp.org workflow completes, confirm the following

After Deploy

  • Merge this branch back into the base branch.
    • If the base branch was trunk, and this release was deployed to WordPress.org, then merge the branch into trunk.
    • If the base branch is the release branch this patch release is for, then merge branch into release branch and then merge the release branch back to trunk if the patch release is the latest released version. Otherwise just merge back into the release branch.
  • If you merged the branch to trunk, then update version on the trunk branch to be for the next version of the plugin and include the dev suffix (e.g. something like 2.6-dev) for the next version.
  • Update the schedules p2 with the shipped date for the release (PdToLP-K-p2).
  • Edit the GitHub milestone of the release you just shipped and add the current date as the due date (this is used to track ship date as well).

Pull request in WooCommerce Core for Package update

This only needs done if the patch release needs to be included in WooCommerce Core. Reviewing and merging the PR is your team's responsibility, except in the case of Fix Release Request. In this case, the WooCommerce release manager reviews and merges the PR.

  • Create a pull request for updating the package in WooCommerce core (based off of the WooCommerce core release branch this is deployed for).

    • The content for the pull release can follow this example.

      • Increase the version of woocommerce/woocommerce-blocks in the plugins/woocommerce/composer.json file

      • Run composer update woocommerce/woocommerce-blocks and make sure composer-lock.json was updated

      • Add a new file similar to this one plugins/woocommerce/changelog/update-woocommerce-blocks-7.4.1 with a similar content as below. For the Significance entry we’ll always use minor, or patch when including a patch release

        Significance: minor
        Type: update
        
            Update WooCommerce Blocks to 7.4.1
    • The PR description can follow this example.

      • It lists all the WooCommerce Blocks versions that are being included since the last version that you edited in plugins/woocommerce/composer.json. Each version should have a link for the Release PR, Testing instructions and Release post (if available).
      • The changelog should be aggregated from all the releases included in the package bump and grouped per type: Enhancements, Bug Fixes, Various etc. This changelog will be used in the release notes for the WooCommerce release. That's why it should only list the PRs that have WooCoomerce Core in the WooCommerce Visibility section of their description. Don't include changes available in the feature plugin or development builds.
  • Run through the testing checklist to ensure everything works in that branch for that package bump. Note: Testing should ensure any features/new blocks that are supposed to be behind feature gating for the core merge of this package update are working as expected.

  • Testing should include completing the Smoke testing checklist. It's up to you to verify that those tests have been done.

  • Verify and make any additional edits to the pull request description for things like: Changelog to be included with WooCommerce core, additional communication that might be needed elsewhere, additional marketing communication notes that may be needed, etc.

    • Assign the corresponding WC version milestone to the PR
    • After the checklist is complete and the testing is done, select the porter of your team to review the PR. Once approved, make sure you merge the PR.
  • Make sure you join the #woo-core-releases Slack channel to represent Woo Blocks for the release of WooCommerce core this version is included in.

Publish Posts

You only need to post public release announcements and update relevant public facing docs if this patch release is deployed to WP.org. Otherwise, you can skip this section.

  • Post release announcement on WooCommerce Developer Blog.
    • Ping porters from each team to know which changelog entries need to be highlighted. Ask them to write a short text and optionally provide a screenshot. They can use previous posts for inspiration, we usually try to highlight new features or API changes.
    • Ensure the release notes are included in the post verbatim.
    • Don't forget to use category WooCommerce Blocks Release Notes for the post.
  • Announce the release internally (#woo-announcements slack).
🚀 This comment was generated by the automations bot triggered by the creation of the branch: release/9.1.1. cc @danieldudzic

@github-actions
Copy link
Contributor Author

The release ZIP for this PR is accessible via:

https://wcblocks.wpcomstaging.com/wp-content/uploads/woocommerce-gutenberg-products-block-7948.zip

* Add `Sort by title` preset.

* sorted, thanks @nerrad
@github-actions
Copy link
Contributor Author

github-actions bot commented Dec 14, 2022

TypeScript Errors Report

Files with errors: 436
Total errors: 2124

⚠️ ⚠️ This PR introduces new TS errors on 5 files:

assets/js/base/components/radio-control-accordion/index.js

assets/js/blocks/cart/inner-blocks/proceed-to-checkout-block/edit.tsx

assets/js/blocks/mini-cart/mini-cart-contents/inner-blocks/mini-cart-footer-block/block.tsx

assets/js/blocks/mini-cart/mini-cart-contents/inner-blocks/mini-cart-shopping-button-block/edit.tsx

node_modules/@wordpress/element/node_modules/@types/react/index.d.ts

@github-actions
Copy link
Contributor Author

github-actions bot commented Dec 14, 2022

Size Change: +31.3 kB (+3%)

Total Size: 1.01 MB

Filename Size Change
build/active-filters-frontend.js 7.75 kB +9 B (0%)
build/active-filters-wrapper-frontend.js 6.01 kB -3 B (0%)
build/all-products-frontend.js 11.3 kB +5 B (0%)
build/all-products.js 33.2 kB +17 B (0%)
build/all-reviews.js 7.79 kB +3 B (0%)
build/attribute-filter-frontend.js 22.6 kB +9 B (0%)
build/attribute-filter-wrapper-frontend.js 7.62 kB +487 B (+7%) 🔍
build/attribute-filter.js 12.3 kB +44 B (0%)
build/cart-blocks/cart-accepted-payment-methods-frontend.js 1.38 kB +3 B (0%)
build/cart-blocks/cart-cross-sells-products--product-add-to-cart-frontend.js 5.48 kB +2 B (0%)
build/cart-blocks/cart-cross-sells-products-frontend.js 4.77 kB -1 B (0%)
build/cart-blocks/cart-express-payment--checkout-blocks/express-payment-frontend.js 5.04 kB +2 B (0%)
build/cart-blocks/cart-items-frontend.js 298 B -1 B (0%)
build/cart-blocks/cart-line-items--mini-cart-contents-block/products-table-frontend.js 5.29 kB +5 B (0%)
build/cart-blocks/cart-line-items-frontend.js 1.06 kB -2 B (0%)
build/cart-blocks/cart-order-summary-frontend.js 1.23 kB -6 B (0%)
build/cart-blocks/filled-cart-frontend.js 779 B -3 B (0%)
build/cart-blocks/order-summary-coupon-form-frontend.js 1.72 kB -1 B (0%)
build/cart-blocks/order-summary-discount-frontend.js 2.16 kB +4 B (0%)
build/cart-blocks/order-summary-fee-frontend.js 274 B +1 B (0%)
build/cart-blocks/order-summary-heading-frontend.js 454 B -1 B (0%)
build/cart-blocks/order-summary-shipping-frontend.js 5.98 kB -3 B (0%)
build/cart-blocks/order-summary-taxes-frontend.js 431 B -4 B (-1%)
build/cart-blocks/proceed-to-checkout-frontend.js 1.19 kB -2 B (0%)
build/cart-frontend.js 46.2 kB +67 B (0%)
build/cart.js 46.4 kB -12 B (0%)
build/checkout-blocks/actions-frontend.js 1.78 kB +9 B (+1%)
build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js 3.9 kB +4 B (0%)
build/checkout-blocks/billing-address-frontend.js 1.09 kB -2 B (0%)
build/checkout-blocks/contact-information-frontend.js 1.79 kB -1 B (0%)
build/checkout-blocks/express-payment-frontend.js 1.13 kB -2 B (0%)
build/checkout-blocks/order-note-frontend.js 1.14 kB -2 B (0%)
build/checkout-blocks/order-summary-cart-items-frontend.js 3.67 kB +4 B (0%)
build/checkout-blocks/order-summary-coupon-form-frontend.js 1.88 kB -4 B (0%)
build/checkout-blocks/order-summary-discount-frontend.js 2.28 kB -4 B (0%)
build/checkout-blocks/order-summary-frontend.js 1.24 kB -2 B (0%)
build/checkout-blocks/order-summary-shipping-frontend.js 6.04 kB -2 B (0%)
build/checkout-blocks/order-summary-taxes-frontend.js 431 B -5 B (-1%)
build/checkout-blocks/payment-frontend.js 8.31 kB -1 B (0%)
build/checkout-blocks/shipping-address-frontend.js 1.07 kB -3 B (0%)
build/checkout-blocks/shipping-methods-frontend.js 5.01 kB +1 B (0%)
build/checkout-frontend.js 48.3 kB +56 B (0%)
build/checkout.js 40.5 kB +1 B (0%)
build/featured-category.js 13.2 kB +42 B (0%)
build/featured-product.js 13.5 kB +49 B (0%)
build/filter-wrapper-frontend.js 13.8 kB +17 B (0%)
build/handpicked-products.js 7.33 kB +39 B (+1%)
build/legacy-template.js 2.86 kB +3 B (0%)
build/mini-cart-component-frontend.js 20 kB +21 B (0%)
build/mini-cart-contents-block/footer-frontend.js 2.96 kB +5 B (0%)
build/mini-cart-contents-block/title-frontend.js 366 B -2 B (-1%)
build/mini-cart-contents.js 17.1 kB -9 B (0%)
build/mini-cart-frontend.js 1.88 kB +1 B (0%)
build/mini-cart.js 4.29 kB -2 B (0%)
build/price-filter-frontend.js 13.6 kB -4 B (0%)
build/price-filter-wrapper-frontend.js 7.01 kB -7 B (0%)
build/price-filter.js 8.37 kB -11 B (0%)
build/product-add-to-cart--product-button--product-category-list--product-image--product-price--product-r--a0326d00.js 225 B -1 B (0%)
build/product-add-to-cart-frontend.js 1.46 kB +3 B (0%)
build/product-add-to-cart.js 8.37 kB +6 B (0%)
build/product-best-sellers.js 7.7 kB +79 B (+1%)
build/product-button--product-category-list--product-image--product-price--product-rating--product-sale-b--e17c7c01.js 440 B +10 B (+2%)
build/product-button--product-image--product-rating--product-sale-badge--product-title.js 300 B -1 B (0%)
build/product-button-frontend.js 2.18 kB +10 B (0%)
build/product-button.js 3.85 kB -3 B (0%)
build/product-categories.js 2.36 kB -1 B (0%)
build/product-category-list-frontend.js 1.14 kB +13 B (+1%)
build/product-category.js 8.69 kB +80 B (+1%)
build/product-image-frontend.js 2.17 kB +9 B (0%)
build/product-image.js 3.93 kB +1 B (0%)
build/product-new.js 7.69 kB +72 B (+1%)
build/product-on-sale.js 8.02 kB +61 B (+1%)
build/product-price-frontend.js 2.17 kB +7 B (0%)
build/product-query.js 5.95 kB +211 B (+4%)
build/product-rating-frontend.js 1.48 kB +10 B (+1%)
build/product-rating.js 814 B -2 B (0%)
build/product-sale-badge-frontend.js 1.39 kB +15 B (+1%)
build/product-sale-badge.js 812 B +1 B (0%)
build/product-search.js 2.62 kB +4 B (0%)
build/product-sku-frontend.js 628 B -1 B (0%)
build/product-stock-indicator-frontend.js 1.27 kB +14 B (+1%)
build/product-stock-indicator.js 646 B +2 B (0%)
build/product-summary-frontend.js 1.53 kB +10 B (+1%)
build/product-summary.js 918 B -2 B (0%)
build/product-tag-list-frontend.js 1.14 kB +13 B (+1%)
build/product-tag.js 8.05 kB +49 B (+1%)
build/product-title-frontend.js 1.59 kB +15 B (+1%)
build/product-top-rated.js 7.93 kB +72 B (+1%)
build/products-by-attribute.js 8.61 kB +78 B (+1%)
build/rating-filter-frontend.js 20.5 kB +13.3 kB (+186%) 🆘
build/rating-filter-wrapper-frontend.js 5.57 kB +156 B (+3%)
build/rating-filter.js 7.27 kB +1.47 kB (+25%) 🚨
build/reviews-by-category.js 11.3 kB +94 B (+1%)
build/reviews-by-product.js 12.4 kB +115 B (+1%)
build/reviews-frontend.js 7.01 kB -10 B (0%)
build/single-product-frontend.js 17.5 kB -22 B (0%)
build/single-product.js 10.1 kB +41 B (0%)
build/stock-filter-frontend.js 20.8 kB +13 kB (+167%) 🆘
build/stock-filter-wrapper-frontend.js 5.85 kB -188 B (-3%)
build/stock-filter.js 8.14 kB +1.43 kB (+21%) 🚨
build/vendors--attribute-filter-wrapper--mini-cart-contents-block/footer--product-add-to-cart-frontend.js 0 B -6.86 kB (removed) 🏆
build/vendors--attribute-filter-wrapper-frontend.js 0 B -8.2 kB (removed) 🏆
build/vendors--cart-blocks/cart-cross-sells-products--cart-blocks/order-summary-shipping--checkout-blocks--18f9376a-frontend.js 19.1 kB -3 B (0%)
build/vendors--cart-blocks/order-summary-shipping--checkout-blocks/billing-address--checkout-blocks/order--5b8feb0b-frontend.js 4.82 kB -39 B (-1%)
build/vendors--cart-blocks/order-summary-shipping--checkout-blocks/order-summary-shipping--checkout-block--dda5866c-frontend.js 8.85 kB -1 B (0%)
build/wc-blocks-editor-style-rtl.css 5.22 kB +38 B (+1%)
build/wc-blocks-editor-style.css 5.23 kB +39 B (+1%)
build/wc-blocks-style-rtl.css 24.4 kB +214 B (+1%)
build/wc-blocks-style.css 24.4 kB +217 B (+1%)
build/wc-blocks-vendors.js 62.7 kB +318 B (+1%)
build/wc-blocks.js 2.63 kB -1 B (0%)
build/vendors--attribute-filter-wrapper--mini-cart-contents-block/footer--product-add-to-cart--rating-fil--b8470171-frontend.js 6.85 kB +6.85 kB (new file) 🆕
build/vendors--attribute-filter-wrapper--rating-filter-wrapper--stock-filter-wrapper-frontend.js 7.69 kB +7.69 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
build/active-filters.js 7.32 kB
build/blocks-checkout.js 27.1 kB
build/cart-blocks/cart-cross-sells-frontend.js 253 B
build/cart-blocks/cart-express-payment-frontend.js 778 B
build/cart-blocks/cart-totals-frontend.js 319 B
build/cart-blocks/empty-cart-frontend.js 346 B
build/cart-blocks/order-summary-subtotal-frontend.js 274 B
build/checkout-blocks/fields-frontend.js 343 B
build/checkout-blocks/order-summary-fee-frontend.js 276 B
build/checkout-blocks/order-summary-subtotal-frontend.js 273 B
build/checkout-blocks/terms-frontend.js 1.63 kB
build/checkout-blocks/totals-frontend.js 325 B
build/filter-wrapper.js 2.4 kB
build/general-style-rtl.css 1.29 kB
build/general-style.css 1.29 kB
build/mini-cart-contents-block/empty-cart-frontend.js 366 B
build/mini-cart-contents-block/filled-cart-frontend.js 230 B
build/mini-cart-contents-block/items-frontend.js 237 B
build/mini-cart-contents-block/products-table-frontend.js 591 B
build/mini-cart-contents-block/shopping-button-frontend.js 288 B
build/price-format.js 1.19 kB
build/product-add-to-cart--product-button--product-image--product-rating--product-title.js 151 B
build/product-category-list.js 503 B
build/product-price.js 1.54 kB
build/product-sku.js 377 B
build/product-tag-list.js 497 B
build/product-title.js 3.3 kB
build/vendors--cart-blocks/cart-cross-sells-products--cart-blocks/cart-line-items--cart-blocks/cart-order--671ca56f-frontend.js 5.26 kB
build/vendors--cart-blocks/cart-cross-sells-products--product-add-to-cart-frontend.js 7.54 kB
build/vendors--cart-blocks/cart-line-items--checkout-blocks/order-summary-cart-items--mini-cart-contents---233ab542-frontend.js 3.14 kB
build/wc-blocks-data.js 18.7 kB
build/wc-blocks-google-analytics.js 1.56 kB
build/wc-blocks-middleware.js 934 B
build/wc-blocks-registry.js 2.92 kB
build/wc-blocks-shared-context.js 1.52 kB
build/wc-blocks-shared-hocs.js 1.73 kB
build/wc-blocks-vendors-style-rtl.css 1.95 kB
build/wc-blocks-vendors-style.css 1.95 kB
build/wc-payment-method-bacs.js 816 B
build/wc-payment-method-cheque.js 811 B
build/wc-payment-method-cod.js 909 B
build/wc-payment-method-paypal.js 837 B
build/wc-settings.js 2.6 kB

compressed-size-action

@github-actions
Copy link
Contributor Author

github-actions bot commented Dec 14, 2022

Script Dependencies Report

The compare-assets action has detected some changed script dependencies between this branch and trunk. Please review and confirm the following are correct before merging.

Script Handle Added Removed
wc-blocks.js wp-blocks, wp-compose, wp-element, wp-hooks, wp-i18n, wp-polyfill, wp-primitives ⚠️
handpicked-products.js lodash, react, wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-polyfill, wp-primitives, wp-server-side-render, wp-url ⚠️
product-best-sellers.js lodash, wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-polyfill, wp-primitives, wp-server-side-render, wp-url ⚠️
product-category.js lodash, wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-polyfill, wp-primitives, wp-server-side-render, wp-url ⚠️
product-categories.js wp-block-editor, wp-blocks, wp-components, wp-element, wp-i18n, wp-polyfill, wp-primitives, wp-server-side-render ⚠️
product-new.js lodash, wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-polyfill, wp-primitives, wp-server-side-render, wp-url ⚠️
product-on-sale.js lodash, wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-polyfill, wp-primitives, wp-server-side-render, wp-url ⚠️
product-top-rated.js lodash, wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-polyfill, wp-primitives, wp-server-side-render, wp-url ⚠️
products-by-attribute.js lodash, wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-polyfill, wp-primitives, wp-server-side-render, wp-url ⚠️
featured-product.js lodash, react, wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives, wp-url ⚠️
all-reviews.js lodash, react, wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives ⚠️
reviews-by-product.js lodash, react, wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives, wp-url ⚠️
reviews-by-category.js lodash, react, wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives, wp-url ⚠️
product-search.js wc-settings, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-element, wp-i18n, wp-polyfill, wp-primitives ⚠️
product-tag.js lodash, wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-element, wp-html-entities, wp-i18n, wp-polyfill, wp-primitives, wp-server-side-render, wp-url ⚠️
featured-category.js lodash, react, wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-element, wp-escape-html, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives, wp-url ⚠️
all-products.js lodash, react, wc-blocks-checkout, wc-blocks-data-store, wc-blocks-registry, wc-blocks-shared-context, wc-blocks-shared-hocs, wc-price-format, wc-settings, wp-a11y, wp-api-fetch, wp-autop, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-deprecated, wp-dom, wp-element, wp-escape-html, wp-hooks, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives, wp-url, wp-warning, wp-wordcount ⚠️
price-filter.js lodash, react, wc-blocks-data-store, wc-price-format, wc-settings, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-element, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives, wp-url ⚠️
attribute-filter.js lodash, react, wc-blocks-checkout, wc-blocks-data-store, wc-settings, wp-a11y, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-deprecated, wp-dom, wp-element, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-keycodes, wp-polyfill, wp-primitives, wp-url, wp-warning ⚠️
stock-filter.js lodash, react, wc-blocks-checkout, wc-blocks-data-store, wc-settings, wp-a11y, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-deprecated, wp-dom, wp-element, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-keycodes, wp-polyfill, wp-primitives, wp-url, wp-warning ⚠️
active-filters.js lodash, react, wc-blocks-data-store, wc-price-format, wc-settings, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-element, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives, wp-url ⚠️
rating-filter.js lodash, react, wc-blocks-checkout, wc-blocks-data-store, wc-settings, wp-a11y, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-deprecated, wp-dom, wp-element, wp-i18n, wp-is-shallow-equal, wp-keycodes, wp-polyfill, wp-primitives, wp-url, wp-warning ⚠️
cart.js lodash, react, wc-blocks-checkout, wc-blocks-data-store, wc-blocks-registry, wc-blocks-shared-context, wc-blocks-shared-hocs, wc-price-format, wc-settings, wp-a11y, wp-api-fetch, wp-autop, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-core-data, wp-data, wp-deprecated, wp-dom, wp-editor, wp-element, wp-hooks, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-keycodes, wp-plugins, wp-polyfill, wp-primitives, wp-url, wp-warning, wp-wordcount ⚠️
checkout.js lodash, react, wc-blocks-checkout, wc-blocks-data-store, wc-blocks-registry, wc-price-format, wc-settings, wp-a11y, wp-api-fetch, wp-autop, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-core-data, wp-data, wp-deprecated, wp-dom, wp-editor, wp-element, wp-hooks, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-keycodes, wp-plugins, wp-polyfill, wp-primitives, wp-url, wp-warning, wp-wordcount ⚠️
mini-cart.js react, wc-price-format, wc-settings, wp-block-editor, wp-blocks, wp-components, wp-dom, wp-element, wp-i18n, wp-polyfill, wp-primitives ⚠️
mini-cart-contents.js lodash, react, wc-blocks-checkout, wc-blocks-data-store, wc-blocks-registry, wc-price-format, wc-settings, wp-a11y, wp-autop, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-deprecated, wp-dom, wp-element, wp-hooks, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-keycodes, wp-polyfill, wp-primitives, wp-url, wp-warning, wp-wordcount ⚠️
single-product.js lodash, react, wc-blocks-checkout, wc-blocks-data-store, wc-blocks-registry, wc-blocks-shared-context, wc-blocks-shared-hocs, wc-price-format, wc-settings, wp-api-fetch, wp-autop, wp-block-editor, wp-blocks, wp-components, wp-compose, wp-data, wp-deprecated, wp-dom, wp-element, wp-escape-html, wp-hooks, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives, wp-url, wp-warning, wp-wordcount ⚠️
legacy-template.js wc-settings, wp-block-editor, wp-blocks, wp-components, wp-data, wp-element, wp-i18n, wp-polyfill, wp-primitives ⚠️
product-query.js lodash, wc-settings, wp-api-fetch, wp-block-editor, wp-blocks, wp-components, wp-data, wp-element, wp-hooks, wp-i18n, wp-polyfill, wp-primitives, wp-url ⚠️
filter-wrapper.js wp-block-editor, wp-blocks, wp-element, wp-i18n, wp-polyfill, wp-primitives ⚠️

This comment was automatically generated by the ./github/compare-assets action.

danieldudzic and others added 13 commits December 14, 2022 15:53
…Products block (#7932)

* Fix the incorrect layout of Rating and Price in Classic Template

There were styles required in Rating Filter that were added globally and influenced the layout of Rating in Products block as well as Classic template. The styles were moved to the Rating Filter block
* Extend Filter by Stock Editor options with dropdown and single/multiple choice

* Add dropdown implementation for Filter by Stock Status

* Adjust font-sizes to the rest of the filters

* Add tests to Filter by Stock: dropdown and list variants

* Change test file extension from .js to .tsx, so it handles types as well

* Add E2E test to Filter by Stock checking if display style can be toggled

* When typing in Filter by Stock dropdown, handle the space so it highlights the suggestions

* Change the name of the filter blocks in the test files

* Remove unnecessary waiting step in E2E test for Filter by Stock

toMatchElement waits for an element for 30s by itself, hence waitForSelector usage was removed

* Improve the STOCK_STATUS_OPTIONS type handling

* Extract onDropdownChange function instead of inline arrow function

* Fix overlaping dropdown content with the wrapper when Filter by Stock was set to single
* Product Query: First attempt at adding patterns

* Product Query: Update patterns and the default block template

* Product Query: And new and update existing patterns

* Product Query: Adjust layout of the Minimal Product Row pattern

* Product Query: Update pattern names

* Product Query: Polish spaces between blocks inside the patterns

* Product Query patterns: Link product titles and improve spacing between product elements

* Product Query patterns: Button font-size update

* Product Query patterns: Center the pagination

* Product Query patterns: Center the pagination for the default pattern

* Product Query patterns: Remove an empty column

* Product Query patterns: Remove an empty column from the product list with 1:1 images pattern
* Rename the setting section to match Filter by Attribute

* Add Display Style toggle to the block settings

* Set list as a default value of displayStyle for Filter by Rating

* Add dropdown variant of Filter by Rating

* Extend the Editor settings with selectType: single or multiple

* Adjust the styles of a FormTokenField to other dropdown

* Align Editor settings order and wording between Filter by Attribute and Rating

* Fix the issue with cut off corners of dropdown borders

* Provide translated screen reader messages and placeholder

* Revert the label property, which is necessary to display checkbox list

* Make classname for Rating component optional and remove styling in Filter by Rating

* Cover the case when filter with zero products needs string methods for comparison

* Handle Typescript errors and add ts-ignore annotations when necessary

* Remove explicit key prop assignment in Rating component

* Remove leftover property in type definition

* Refactor JSX element extension with custom properties to more robust way with object copy

* Filter by rating tests (#7845)

* Filter by Rating tests:
  - List single
  - List multiple
  - Dropdown single
  - Dropdown multiple

* Adjust the font-size of Filter by Rating dropdown to the rest of the filters

* Fix E2E tests after the Editor settings label has been changed

* Improve sorting in Filter by Rating dropdown

With this change the order of options is always descending: in the chips, suggestions, active filters and URL

* Change the name of the filter blocks in the test files

* Prevent single dropdown input to overflow the wrapper

The issue is fixed in three filters, hence a new shared styles file is created at the path assets/js/blocks/shared/styles/style.css

* Remove the unused styles of active options in Filter by Rating

Chosen options in Filter by Rating list have been bolded. That was the only filter that was doing it. Class was removed, but not the styles themselves which became obsolete. Removing the leftover styles then

* Change the approach of shared styles to fix the dropdown issue in filters

Instead of using direct classes, rewrite it to mixin and include in the filters

* Fix the Filter by Rating with Products block

The problem was with the Products block, that there was incorrect initial value of product ratings query

* Align the logic of getting the filters from URL for Filter by Rating with Filter by Stock

Co-authored-by: Luigi Teschio <gigitux@gmail.com>
* Add Inherit Query from template option

* Update label
* Product Elements: Fix block settings

* Rating: Fix inactive star color

* Product Rating: Fix color inheritance
* StyleAttributesUtils: Fix PHP notices and invalid CSS output. Closes #7899.

* StyleAttributesUtils: Fix border radius and width support

* StyleAttributesUtils: Fix border radius and border color support

* StyleAttributesUtils: Include additional checks to deal with PHP warnings

* StyleAttributesUtils: Improve the custom border array check
… including tax (#7832)

* Update MiniCart.php

Added an update to the '$cart_contents_total' variable on the 'get_cart_price_markup' function if $cart->display_prices_including_tax is active. Currently displaying wrong amount total on page load if items are already in the basket.

* Update MiniCart.php

Removed white spaces?

* Update MiniCart.php

Fixed IF statement

* Remove whitespace at end of line

Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
…7792)

* Product Query: implement compatibility with Filter by Rating block #7631

Product Query: implement compatibility with Filter by Rating block

* address feedback

* address feedback

* add comment
Copy link
Contributor

@Aljullu Aljullu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Product Query - Enable "Inherit Query from template" option to the last one, everything seems to be working well. However, I left several suggestions to improve the testing steps. If you agree with them, they can be merged directly.

docs/internal-developers/testing/releases/911.md Outdated Show resolved Hide resolved
2. Add **Button**, **Price** and **Rating** product elements.
3. Customize via block settings:

- **Product Price**: `background color` and `appearance`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see appearance here:

Suggested change
- **Product Price**: `background color` and `appearance`.
- **Product Price**: `text color` and `background color`.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here:
image

3. Customize via block settings:

- **Product Price**: `background color` and `appearance`.
- **Product Button**: `font-weight` and `padding`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see font-weight here: 😕

Suggested change
- **Product Button**: `font-weight` and `padding`.
- **Product Button**: `padding`.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it refers to the Typography section.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I update these lines in this way:

- **Product Price**:  `Color > background`, `Color > text ` and `Typography > Appearance`.
- **Product Button**: `Typography > font-weight` and `Dimension > padding`.
- **Product Rating**: `Typography > font-size`, `Dimension > margin`, `Color > text`.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

docs/internal-developers/testing/releases/911.md Outdated Show resolved Hide resolved
docs/internal-developers/testing/releases/911.md Outdated Show resolved Hide resolved
docs/internal-developers/testing/releases/911.md Outdated Show resolved Hide resolved
gigitux and others added 6 commits December 14, 2022 17:49
Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
Copy link
Contributor

@Aljullu Aljullu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the dropdown filter PRs and they are working well too. 👍

Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
Copy link
Contributor

@nefeline nefeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aljullu , @gigitux, and I tested all features/updates and confirmed they are a-ok for the release 🚀

@gigitux gigitux merged commit 7856186 into release/9.1.0 Dec 15, 2022
@gigitux gigitux deleted the release/9.1.1 branch December 15, 2022 09:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants