This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Implement @wordpress/scripts analyze script
#5589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
tools
rubikuserbot
requested review from
a team and
opr
and removed request for
a team
|
Size Change: 0 B Total Size: 816 kB ℹ️ View Unchanged
|
opr
approved these changes
Jan 21, 2022
mikejolley
force-pushed
the
add/bundle-analyzer
branch
from
4676816
to
27a74f0
Compare
|
e2e fails are unrelated. |
|
@mikejolley with this PR, I got the following error when I tried to build the assets. Both my current workspace and fresh clone have the same issue. Checking out the former commit (9d4ab23), I could build the plugin as normal. Do you have the same issue? I'm using a M1 Mac Mini, not sure if it plays any role here.
|
mikejolley
added a commit
that referenced
this pull request
Jan 28, 2022
|
@dinhtungdu thanks for heads up, unit tests wound't have caught the dev build. It was a deleted line - fixed in 7579601 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
source-map-explorerand thenpm run explorecommand with the@wordpress/scriptsequivilent. This can be ran withnpm run analyze-bundlesgenerating output like this:This was based on the work in Gutenberg here.
Fixes #5028
Testing
How to test the changes in this Pull Request:
npm installnpm run analyze-bundles