Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Remove order note #2318

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Remove order note #2318

merged 1 commit into from
Apr 28, 2020

Conversation

senadir
Copy link
Member

@senadir senadir commented Apr 27, 2020

The checkbox for order note was there in we did the skeleton for the checkout, we never implemented but it’s still visible.
We will tackle this later, for now, I'm deleting it so people don't experience a broken feature.

Fixes #2308

image

@senadir senadir added the type: bug The issue/PR concerns a confirmed bug. label Apr 27, 2020
@senadir senadir requested a review from a team as a code owner April 27, 2020 13:40
@senadir senadir self-assigned this Apr 27, 2020
@senadir senadir requested review from Aljullu and removed request for a team April 27, 2020 13:40
@github-actions
Copy link
Contributor

Size Change: -56 B (0%)

Total Size: 1.73 MB

Filename Size Change
build/checkout-frontend.js 116 kB -30 B (0%)
build/checkout.js 34.9 kB -26 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/active-filters-frontend.js 7.53 kB 0 B
build/active-filters.js 8.3 kB 0 B
build/all-products-frontend.js 17.9 kB 0 B
build/all-products.js 17.9 kB 0 B
build/all-reviews-legacy.js 10.8 kB 0 B
build/all-reviews.js 11 kB 0 B
build/attribute-filter-frontend.js 17 kB 0 B
build/attribute-filter.js 11.8 kB 0 B
build/block-error-boundary-legacy.js 774 B 0 B
build/block-error-boundary.js 774 B 0 B
build/blocks-legacy.js 2.92 kB 0 B
build/blocks.js 2.92 kB 0 B
build/cart-frontend.js 112 kB 0 B
build/cart.js 32.4 kB 0 B
build/custom-select-control-style-legacy.js 782 B 0 B
build/custom-select-control-style.js 782 B 0 B
build/editor-legacy-rtl.css 12.6 kB 0 B
build/editor-legacy.css 12.6 kB 0 B
build/editor-rtl.css 13.6 kB 0 B
build/editor.css 13.6 kB 0 B
build/featured-category-legacy.js 146 kB 0 B
build/featured-category.js 146 kB 0 B
build/featured-product-legacy.js 9.42 kB 0 B
build/featured-product.js 9.73 kB 0 B
build/handpicked-products-legacy.js 7.27 kB 0 B
build/handpicked-products.js 7.57 kB 0 B
build/panel-style-legacy.js 774 B 0 B
build/panel-style.js 774 B 0 B
build/price-filter-frontend.js 14.1 kB 0 B
build/price-filter.js 10.4 kB 0 B
build/product-best-sellers-legacy.js 7.37 kB 0 B
build/product-best-sellers.js 7.64 kB 0 B
build/product-categories-legacy.js 3.2 kB 0 B
build/product-categories.js 3.19 kB 0 B
build/product-category-legacy.js 8.27 kB 0 B
build/product-category.js 8.55 kB 0 B
build/product-list-style-legacy.js 776 B 0 B
build/product-new-legacy.js 7.52 kB 0 B
build/product-new.js 7.8 kB 0 B
build/product-on-sale-legacy.js 7.87 kB 0 B
build/product-on-sale.js 8.2 kB 0 B
build/product-search-legacy.js 3.61 kB 0 B
build/product-search.js 3.85 kB 0 B
build/product-tag-legacy.js 6.45 kB 0 B
build/product-tag.js 6.72 kB 0 B
build/product-top-rated-legacy.js 7.5 kB 0 B
build/product-top-rated.js 7.77 kB 0 B
build/products-by-attribute-legacy.js 8.22 kB 0 B
build/products-by-attribute.js 8.49 kB 0 B
build/reviews-by-category-legacy.js 12.8 kB 0 B
build/reviews-by-category.js 13.1 kB 0 B
build/reviews-by-product-legacy.js 14.2 kB 0 B
build/reviews-by-product.js 14.5 kB 0 B
build/reviews-frontend-legacy.js 8.42 kB 0 B
build/reviews-frontend.js 9.12 kB 0 B
build/snackbar-notice-style-legacy.js 778 B 0 B
build/snackbar-notice-style.js 779 B 0 B
build/spinner-style-legacy.js 772 B 0 B
build/spinner-style.js 772 B 0 B
build/style-legacy-rtl.css 5.37 kB 0 B
build/style-legacy.css 5.38 kB 0 B
build/style-rtl.css 15.4 kB 0 B
build/style.css 15.4 kB 0 B
build/vendors-legacy.js 280 kB 0 B
build/vendors-style-legacy-rtl.css 1.65 kB 0 B
build/vendors-style-legacy.css 1.65 kB 0 B
build/vendors-style-legacy.js 105 B 0 B
build/vendors-style-rtl.css 1.65 kB 0 B
build/vendors-style.css 1.65 kB 0 B
build/vendors-style.js 105 B 0 B
build/vendors.js 366 kB 0 B
build/wc-blocks-data.js 7.01 kB 0 B
build/wc-blocks-registry.js 1.58 kB 0 B
build/wc-payment-method-cheque.js 783 B 0 B
build/wc-payment-method-stripe.js 10.7 kB 0 B
build/wc-settings.js 2.14 kB 0 B

compressed-size-action

Copy link
Contributor

@Aljullu Aljullu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small comment but pre-approving.

@@ -347,13 +347,6 @@ const Checkout = ( { attributes, scrollToTop } ) => {
}
/>
) }
{ /*@todo This is not implemented*/ }
<CheckboxControl
className="wc-block-checkout__add-note"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the CSS selector targeting this checkbox?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep it; I think I'll give adding this back a shot during cooldown once all other issues are resolved :) Ref #1483

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkout: Order notes component not usable
4 participants