This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Related Products: hide the block outside of Single Product Template and Single Product block #10978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +118 B (0%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
…ed for single product
kmanijak
added
block-type: product
woocommercebot
requested review from
a team and
nefeline
and removed request for
a team
danielwrobert
approved these changes
Sep 16, 2023
gigitux
force-pushed
the
fix/10959-related-products-available-outside-single-product
branch
from
1f9dc24 to
1483007
Compare
kmanijak
deleted the
fix/10959-related-products-available-outside-single-product
branch
15 tasks
tarunvijwani
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
There was a bug that Related Products block was available in the inserter outside of Single Product template which caused a fatal error when trying to save the template. Related Product is supposed to be used only within Single Product template and Single Product block.
This PR improves the logic of
registerBlockSingleProductTemplatefunction.Fixes #10959
Why
Changes:
Removing the
ancestorparameter fromregisterBlockVariationfunction since variation doesn't supportancestorproperty. This change doesn't influence the logic, but is added to decrease complexity of the function.Provide the default value of
ancestorfield when registering the blocks viaregisterBlockSingleProductTemplate. As the function name suggests the blocks should only be available within thesingle-producttemplate or block. While block didn't provide this property it was actually registered globally as it happened in case of Related Products block. So now if the block doesn't provideancestorfield we fallback toancestor: [ 'woocommerce/single-product' ].Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog