This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Interactivity API: Disable scroll for Pagination block links inside Product Query #10522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAreRodz
added
the
block-type: product-query
7 tasks
|
The release ZIP for this PR is accessible via: TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. Script Dependencies ReportThe
This comment was automatically generated by the |
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
imanish003
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Hey @DAreRodz, thank you for addressing this. I have a small suggestion that isn't a blocker. Considering its minor nature, I'm pre-approving the PR 🚀
| @@ -138,7 +138,7 @@ public function add_navigation_link_directives( $block_content, $block, $instanc | |||
|
|
|||
| $navigation_link_payload = array( | |||
| 'prefetch' => $is_previous_or_next, | |||
| 'scroll' => true, | |||
| 'scroll' => false, | |||
There was a problem hiding this comment.
Nitpicking: I believe it would enhance the code if we could eliminate the need to explicitly pass false when we don't intend to enable the scroll functionality. Perhaps we can modify the condition here to achieve this. What are your thoughts on this?
There was a problem hiding this comment.
We would have to decide what behavior we want to have by default. 🤔 Depending on the API we'd take as an inspiration, the scroll value would be:
- true
location.assign()location.replace()navigation.navigate()(experimental 🧪)
- false
I prefer to follow what the future navigation.navigate() API is doing, i.e., to let the browser decide (most of the time, it would be scrolling by default). In any case, I think it would be a good idea to set the scroll behavior explicitly, at least for now.
Pinging @luisherranz in case he wants to add anything else. 🙂
There was a problem hiding this comment.
For full-page client-side navigation, there's no doubt that the default should be scroll to the top.
For inner-content client-side navigation (what we are doing here), I'm not so sure. Maybe defaulting to not scrolling makes more sense.
So good points 🙂
Let's leave the default as true for now, but keep an eye on it!
luisherranz
approved these changes
Aug 10, 2023
DAreRodz
deleted the
fix/products-block-disable-scroll-in-pagination-links
branch
nielslange
added
type: enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #10200
Make links inside a Pagination block not to scroll to the top of the page, as requested in #10200 (comment).
Testing
User Facing Testing