Remove attributes data from save function for active filters

[roykho]

Fixes #9959

This PR removes the data attributes from being saved into HTML as it is not needed. A deprecation has been also implemented to prevent block validation errors on existing blocks.

Testing

User Facing Testing

1. Log in to your WordPress dashboard.
2. Create a new post / page.
3. Click on the "+" button in the top left corner of the editor to add a new block. Search and add the following blocks to the editor: Products (beta), Active Filters and some filter block like the Filter by attributes.
4. On the top-right side, click on the Save button.
5. Visit the post/page that you just created and check that Active Filters block is working correctly when choosing different options from the Filter by Attributes block

• Do not include in the Testing Notes

WooCommerce Visibility

• WooCommerce Core
• Feature plugin
• Experimental

Performance Impact

Changelog

Remove attributes data from saving in HTML for Active Filters block

[github-actions]

The release ZIP for this PR is accessible via:

https://wcblocks.wpcomstaging.com/wp-content/uploads/woocommerce-gutenberg-products-block-10047.zip

Script Dependencies Report

There is no changed script dependency between this branch and trunk.

This comment was automatically generated by the ./github/compare-assets action.

TypeScript Errors Report

• Files with errors: 463
• Total errors: 2236

🎉 🎉 This PR does not introduce new TS errors.

_{comments-aggregator}

[github-actions]

Size Change: +47 B (0%)

Total Size: 1.18 MB

Filename	Size	Change
build/active-filters.js	7.54 kB	+55 B (+1%)
build/all-products.js	41.1 kB	-7 B (0%)
build/attribute-filter.js	13.3 kB	-4 B (0%)
build/cart.js	45.4 kB	+3 B (0%)
build/checkout.js	47.9 kB	+4 B (0%)
build/legacy-template.js	8.92 kB	-3 B (0%)
build/mini-cart-contents.js	18.1 kB	-1 B (0%)
build/price-filter.js	8.59 kB	+1 B (0%)
build/product-add-to-cart.js	8.84 kB	+1 B (0%)
build/product-price.js	1.69 kB	+2 B (0%)
build/product-query.js	11.9 kB	-1 B (0%)
build/product-title.js	3.66 kB	+1 B (0%)
build/rating-filter.js	6.92 kB	-2 B (0%)
build/reviews-by-category.js	12.1 kB	+1 B (0%)
build/single-product.js	11.1 kB	-2 B (0%)
build/stock-filter.js	7.67 kB	-1 B (0%)

ℹ️ View Unchanged

Filename	Size
build/active-filters-frontend.js	8.64 kB
build/active-filters-wrapper-frontend.js	7.58 kB
build/all-products-frontend.js	12.3 kB
build/all-reviews.js	7.86 kB
build/attribute-filter-frontend.js	23 kB
build/attribute-filter-wrapper-frontend.js	7.74 kB
build/blocks-checkout.js	35.1 kB
build/breadcrumbs.js	2.13 kB
build/cart-blocks/cart-accepted-payment-methods-frontend.js	1.38 kB
build/cart-blocks/cart-cross-sells-frontend.js	253 B
build/cart-blocks/cart-cross-sells-products--product-price-frontend.js	2.92 kB
build/cart-blocks/cart-cross-sells-products-frontend.js	3.83 kB
build/cart-blocks/cart-express-payment--checkout-blocks/express-payment-frontend.js	5.16 kB
build/cart-blocks/cart-express-payment-frontend.js	720 B
build/cart-blocks/cart-items-frontend.js	301 B
build/cart-blocks/cart-line-items--mini-cart-contents-block/products-table-frontend.js	5.47 kB
build/cart-blocks/cart-line-items-frontend.js	1.06 kB
build/cart-blocks/cart-order-summary-frontend.js	1.28 kB
build/cart-blocks/cart-totals-frontend.js	307 B
build/cart-blocks/empty-cart-frontend.js	347 B
build/cart-blocks/filled-cart-frontend.js	656 B
build/cart-blocks/order-summary-coupon-form-frontend.js	1.63 kB
build/cart-blocks/order-summary-discount-frontend.js	2.12 kB
build/cart-blocks/order-summary-fee-frontend.js	273 B
build/cart-blocks/order-summary-heading-frontend.js	333 B
build/cart-blocks/order-summary-shipping-frontend.js	17 kB
build/cart-blocks/order-summary-subtotal-frontend.js	274 B
build/cart-blocks/order-summary-taxes-frontend.js	436 B
build/cart-blocks/proceed-to-checkout-frontend.js	1.44 kB
build/cart-frontend.js	29.9 kB
build/catalog-sorting.js	1.7 kB
build/checkout-blocks/actions-frontend.js	1.88 kB
build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js	4.69 kB
build/checkout-blocks/billing-address-frontend.js	1.18 kB
build/checkout-blocks/contact-information-frontend.js	2.04 kB
build/checkout-blocks/express-payment-frontend.js	1.14 kB
build/checkout-blocks/fields-frontend.js	332 B
build/checkout-blocks/order-note-frontend.js	1.14 kB
build/checkout-blocks/order-summary-cart-items-frontend.js	3.76 kB
build/checkout-blocks/order-summary-coupon-form-frontend.js	1.79 kB
build/checkout-blocks/order-summary-discount-frontend.js	2.29 kB
build/checkout-blocks/order-summary-fee-frontend.js	275 B
build/checkout-blocks/order-summary-frontend.js	1.28 kB
build/checkout-blocks/order-summary-shipping-frontend.js	17 kB
build/checkout-blocks/order-summary-subtotal-frontend.js	273 B
build/checkout-blocks/order-summary-taxes-frontend.js	435 B
build/checkout-blocks/payment-frontend.js	9.27 kB
build/checkout-blocks/pickup-options-frontend.js	4.84 kB
build/checkout-blocks/shipping-address-frontend.js	1.17 kB
build/checkout-blocks/shipping-method-frontend.js	2.63 kB
build/checkout-blocks/shipping-methods-frontend.js	6.41 kB
build/checkout-blocks/terms-frontend.js	1.56 kB
build/checkout-blocks/totals-frontend.js	361 B
build/checkout-frontend.js	31.8 kB
build/customer-account.js	3.19 kB
build/featured-category.js	15.1 kB
build/featured-product.js	15.3 kB
build/filter-wrapper-frontend.js	14.2 kB
build/filter-wrapper.js	2.4 kB
build/general-style-rtl.css	1.31 kB
build/general-style.css	1.31 kB
build/handpicked-products.js	8.04 kB
build/mini-cart-component-frontend.js	30.8 kB
build/mini-cart-contents-block/cart-button-frontend.js	1.73 kB
build/mini-cart-contents-block/checkout-button-frontend.js	1.81 kB
build/mini-cart-contents-block/empty-cart-frontend.js	360 B
build/mini-cart-contents-block/filled-cart-frontend.js	267 B
build/mini-cart-contents-block/footer-frontend.js	3.83 kB
build/mini-cart-contents-block/items-frontend.js	237 B
build/mini-cart-contents-block/products-table-frontend.js	588 B
build/mini-cart-contents-block/shopping-button-frontend.js	530 B
build/mini-cart-contents-block/title-frontend.js	1.89 kB
build/mini-cart-contents-block/title-items-counter-frontend.js	1.59 kB
build/mini-cart-contents-block/title-label-frontend.js	1.53 kB
build/mini-cart-frontend.js	2.84 kB
build/mini-cart.js	5.93 kB
build/price-filter-frontend.js	14.7 kB
build/price-filter-wrapper-frontend.js	6.79 kB
build/price-format.js	1.19 kB
build/product-add-to-cart--product-button--product-image--product-price--product-rating--product-rating-s--92e2d51d.js	271 B
build/product-add-to-cart--product-button--product-image--product-rating--product-rating-stars--product-title.js	151 B
build/product-add-to-cart-frontend.js	6.53 kB
build/product-best-sellers.js	8.36 kB
build/product-button--product-image--product-price--product-rating--product-rating-stars--product-sale-ba--4e6a8b3c.js	952 B
build/product-button-frontend.js	2.66 kB
build/product-button.js	3.97 kB
build/product-categories.js	2.72 kB
build/product-category.js	9.37 kB
build/product-collection.js	12.3 kB
build/product-image-frontend.js	2.71 kB
build/product-image.js	4.21 kB
build/product-new.js	8.65 kB
build/product-on-sale.js	8.65 kB
build/product-price-frontend.js	231 B
build/product-rating-frontend.js	2.35 kB
build/product-rating-stars-frontend.js	2.24 kB
build/product-rating-stars.js	939 B
build/product-rating.js	1.04 kB
build/product-results-count.js	1.66 kB
build/product-sale-badge-frontend.js	1.8 kB
build/product-sale-badge.js	665 B
build/product-search.js	2.63 kB
build/product-sku-frontend.js	1.85 kB
build/product-sku.js	534 B
build/product-stock-indicator-frontend.js	2.04 kB
build/product-stock-indicator.js	728 B
build/product-summary-frontend.js	2.26 kB
build/product-summary.js	1 kB
build/product-tag.js	8.87 kB
build/product-template.js	3.34 kB
build/product-title-frontend.js	2.22 kB
build/product-top-rated.js	8.91 kB
build/products-by-attribute.js	9.76 kB
build/rating-filter-frontend.js	21.4 kB
build/rating-filter-wrapper-frontend.js	6.23 kB
build/reviews-by-product.js	13.3 kB
build/reviews-frontend.js	7.17 kB
build/stock-filter-frontend.js	21.7 kB
build/stock-filter-wrapper-frontend.js	6.5 kB
build/store-notices.js	1.69 kB
build/vendors--attribute-filter-wrapper--cart-blocks/order-summary-coupon-form--cart-blocks/order-summary--48e1e4bb-frontend.js	6.83 kB
build/vendors--attribute-filter-wrapper--cart-blocks/order-summary-shipping--checkout-blocks/billing-addr--d9f38f9d-frontend.js	4.2 kB
build/vendors--attribute-filter-wrapper-frontend.js	5.11 kB
build/vendors--cart-blocks/cart-cross-sells-products--cart-blocks/cart-line-items--cart-blocks/cart-order--3c5fe802-frontend.js	5.26 kB
build/vendors--cart-blocks/cart-line-items--checkout-blocks/order-summary-cart-items--mini-cart-contents---233ab542-frontend.js	3.57 kB
build/vendors--cart-blocks/order-summary-shipping--checkout-blocks/billing-address--checkout-blocks/order--decc3dc6-frontend.js	19.4 kB
build/vendors--checkout-blocks/pickup-options--checkout-blocks/shipping-methods-frontend.js	8.25 kB
build/vendors--checkout-blocks/shipping-method-frontend.js	12.4 kB
build/vendors--price-filter-wrapper-frontend.js	2.2 kB
build/vendors--product-add-to-cart-frontend.js	7.25 kB
build/vendors--rating-filter-wrapper-frontend.js	5.11 kB
build/vendors--stock-filter-wrapper-frontend.js	5.11 kB
build/wc-blocks-data.js	22.4 kB
build/wc-blocks-editor-style-rtl.css	6.35 kB
build/wc-blocks-editor-style.css	6.34 kB
build/wc-blocks-google-analytics.js	1.56 kB
build/wc-blocks-middleware.js	934 B
build/wc-blocks-registry.js	3.15 kB
build/wc-blocks-shared-context.js	1.1 kB
build/wc-blocks-shared-hocs.js	1.75 kB
build/wc-blocks-style-rtl.css	28 kB
build/wc-blocks-style.css	28 kB
build/wc-blocks-vendors-style-rtl.css	1.96 kB
build/wc-blocks-vendors-style.css	1.96 kB
build/wc-blocks-vendors.js	65.2 kB
build/wc-blocks.js	3.74 kB
build/wc-interactivity.js	10.4 kB
build/wc-payment-method-bacs.js	816 B
build/wc-payment-method-cheque.js	811 B
build/wc-payment-method-cod.js	909 B
build/wc-payment-method-paypal.js	837 B
build/wc-settings.js	2.6 kB
build/wc-shipping-method-pickup-location.js	30.4 kB

_{compressed-size-action}

[Aljullu]

It's testing well and code looks good, thanks @roykho!

Should we update the Active Filters fixture? Or maybe even create a separate one for the new markup?