-
Notifications
You must be signed in to change notification settings - Fork 133
Add SqLite 2.6.1 dependency #14699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Add SqLite 2.6.1 dependency #14699
Conversation
Added `androidx.sqlite` and `androidx.sqlite.framework` as dependencies to the FluxC library.
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
Project dependencies changeslist! Upgraded Dependencies
androidx.sqlite:sqlite:2.6.1, (changed from 2.5.1)
androidx.sqlite:sqlite-android:2.6.1, (changed from 2.5.1)
androidx.sqlite:sqlite-framework:2.6.1, (changed from 2.5.1)
androidx.sqlite:sqlite-framework-android:2.6.1, (changed from 2.5.1) tree +--- androidx.work:work-runtime-ktx:2.10.5
| \--- androidx.work:work-runtime:2.10.5
| \--- androidx.room:room-ktx:2.6.1 -> 2.7.2
| \--- androidx.room:room-runtime:2.7.2
| \--- androidx.room:room-runtime-android:2.7.2
-| +--- androidx.sqlite:sqlite:2.5.1
-| | \--- androidx.sqlite:sqlite-android:2.5.1
-| | +--- androidx.annotation:annotation:1.8.1 -> 1.9.1 (*)
-| | +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
-| | +--- androidx.sqlite:sqlite-framework:2.5.1 (c)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.10 -> 2.2.0 (c)
+| +--- androidx.sqlite:sqlite:2.5.1 -> 2.6.1
+| | \--- androidx.sqlite:sqlite-android:2.6.1
+| | +--- androidx.annotation:annotation:1.9.1 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
+| | +--- androidx.sqlite:sqlite-framework:2.6.1 (c)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.20 -> 2.2.0 (c)
-| \--- androidx.sqlite:sqlite-framework:2.5.1
-| \--- androidx.sqlite:sqlite-framework-android:2.5.1
-| +--- androidx.annotation:annotation:1.8.1 -> 1.9.1 (*)
-| +--- androidx.sqlite:sqlite:2.5.1 (*)
-| +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
-| +--- androidx.sqlite:sqlite:2.5.1 (c)
-| \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.10 -> 2.2.0 (c)
+| \--- androidx.sqlite:sqlite-framework:2.5.1 -> 2.6.1
+| \--- androidx.sqlite:sqlite-framework-android:2.6.1
+| +--- androidx.annotation:annotation:1.8.1 -> 1.9.1 (*)
+| +--- androidx.sqlite:sqlite:2.6.1 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
+| +--- androidx.sqlite:sqlite:2.6.1 (c)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.20 -> 2.2.0 (c)
-\--- project :libs:cardreader
- \--- com.stripe:stripeterminal-taptopay:4.6.0
- \--- com.stripe:stripeterminal-internal-common:4.6.0
- \--- app.cash.sqldelight:android-driver:2.0.2
- +--- androidx.sqlite:sqlite-framework:2.4.0 -> 2.5.1 (*)
- \--- androidx.sqlite:sqlite:2.4.0 -> 2.5.1 (*)
++--- project :libs:fluxc
+ +--- androidx.sqlite:sqlite:2.6.1 (*)
+ \--- androidx.sqlite:sqlite-framework:2.6.1 (*)
+\--- project :libs:cardreader
+ \--- com.stripe:stripeterminal-taptopay:4.6.0
+ \--- com.stripe:stripeterminal-internal-common:4.6.0
+ \--- app.cash.sqldelight:android-driver:2.0.2
+ +--- androidx.sqlite:sqlite-framework:2.4.0 -> 2.6.1 (*)
+ \--- androidx.sqlite:sqlite:2.4.0 -> 2.6.1 (*) |
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Again nice find about the bug @irfano. Before reviewing this @irfano, I wanted to get your opinion on the best approach, WDYT about updating Room to the latest version instead? The last version 2.8.1 uses SQLite 2.6.1 (As the list of commits shows from the release notes page). We already have a pending PR to update Room to 2.8.0, so if we go straight to 2.8.1, we'll save time. Personally I don't have a strong opinion, but I would prefer to avoid adding more dependency references, and instead allow Room to bring the compatible dependencies. |
Description
This upgrades SQLite to version 2.6.1, which includes fixes for several issues. See the Slack discussion for details: p1759486799743309/1759469754.623059-slack-C6H8C3G23.
Steps to reproduce
Run
./gradlew assembleDebug --scan
, and in the generated report, check the dependencies section to verify that SqLite 2.6.1 is being used.The tests that have been performed
I compared the assembleDebug reports between
trunk
and this PR, and verified that SQLite has been upgraded from version 2.5.1 to 2.6.1.Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.