-
Notifications
You must be signed in to change notification settings - Fork 133
[WOOMOB-1411][Woo POS][Surveys] Add local notification infrastructure for Woo POS surveys #14694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WOOMOB-1411][Woo POS][Surveys] Add local notification infrastructure for Woo POS surveys #14694
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #14694 +/- ##
============================================
- Coverage 38.36% 38.36% -0.01%
- Complexity 9841 9842 +1
============================================
Files 2097 2097
Lines 116954 116993 +39
Branches 15651 15654 +3
============================================
+ Hits 44873 44880 +7
- Misses 67915 67948 +33
+ Partials 4166 4165 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM, I've left one question.
<string name="local_notification_blaze_abandoned_campaign_reminder_title">Thinking about boosting your sales?</string> | ||
<string name="local_notification_blaze_abandoned_campaign_reminder_description">Get your products seen by millions with Blaze and boost your sales</string> | ||
<string name="local_notification_woo_pos_survey_potential_user_title">Thinking about in-person sales?</string> | ||
<string name="local_notification_woo_pos_survey_potential_user_description">Help us build tools you\'d actually use. 2 minutes.</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this string correct? The "2 minutes" part feels out of place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Fixed the copy - ba0246c
…ing-a-local-notification-that
WOOMOB-1411
Description
Adds the base infrastructure for local push notifications for Woo POS surveys. This PR creates two notification types:
Potential users survey - targets merchants who haven't used POS yet
Current users survey - targets merchants actively using POS
The implementation includes:
This PR does not include the triggering logic - that will be added in a follow-up PR.
Steps to reproduce
This is infrastructure only. No user-facing changes yet.
Testing information
The tests that have been performed
Build verification
Code review of infrastructure components
I have considered if this change warrants release notes and have added them to
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.