-
Notifications
You must be signed in to change notification settings - Fork 145
Conversation
remove jest-environment-jsdom-sixteen.
There is one failing test:
But, AFAI Can Tell it should fail, as there is no reason why I have no idea how and why this test passed before. |
BTW, I don't know why we use IMO, we should write something like: test( 'should render empty message when there are no rows', () => {
// ...
expect( leaderboard ).to.contain( 'EmptyTable' )
expect( leaderboard ).to.have.rendered.text( 'No data recorded for the selected time period' );
} ); |
There is no reason why <EmptyTable> should have 5 rows. There is no such prop being passed.
@tomalec just a heads up in relation to this PR (given it is still in draft). The reason we are still using If you do go ahead with this, it would be great to get some info on the performance difference, is it still relevant or not? (We might even want to try Jest 27 now). |
@tomalec @louwie17 I tried jest 27 lately its a lot faster, but I had trouble getting some tests working. @tomalec Also I'm happy to delete the failing snapshot test. I encouraged the team to stop writing snapshot tests because of what you say which is they're basically useless for testing anything (and very fragile). If its possible to write a corresponding basic test for the removed snapshot one then great, but I wouldn't block on that either. |
Thanks for all the info :) Given my local env problems related to #7378 are now solved ( |
I started this with a hope to address
window
/jsdom
problems encountered in #7378 (comment)Also, this PR may help with #7218 (comment)
jest@26.6.3
(from24.9.0
), removejest-environment-jsdom-sixteen
, to somewhat reduce our technical debt.legacy
as that is what was actually used before. AFAIKjest-environment-jsdom-sixteen
was hardcoding it as legacy regardless of config.<Leaderboard>
component - I have no idea how and why it passed before. See below.Accessibility
n/a this PR affects only dev tooling, and updates existing dependencies.
Screenshots
Detailed test instructions:
npm run test
no changelog needed - this changes only dev tooling