This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Remove the use of Dashicons and replace with @wordpress/icons or gridicons
#7020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs changelog entry
and removed
needs changelog entry
labels
|
The only icon that looked a little different from the dashicons was the calendar icon, cc'ing @elizaan36 if this is ok? We should otherwise be able to add the dashicon calendar icon to the |
|
I think the updated WordPress icon looks way better and simpler than the Dashicons one.👍 |
louwie17
force-pushed
the
update/3613_old_dashicons
branch
from
179d254
to
b46216a
Compare
samueljseay
approved these changes
May 24, 2021
There was a problem hiding this comment.
Looks awesome to me. Thank you @louwie17 this is really high impact! 🚀
|
Note, you'll just need to merge recent changes to work around e2e issues |
louwie17
force-pushed
the
update/3613_old_dashicons
branch
from
b46216a
to
d855979
Compare
louwie17
force-pushed
the
update/3613_old_dashicons
branch
from
d855979
to
91cf817
Compare
ObliviousHarmony
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Mar 18, 2022
…ridicons` (woocommerce/woocommerce-admin#7020) * Updated mobile banner icon with cross-small gridicon * Update analytics dashboard icons, removing use of dashicon * Remove use of dash icon in tag component * Remove dash icon from ellipsis menu * Remove use of dashicon in calendar * Update icon imports and remove use of Dashicon in collapsible list * Remove Dashicon usage from store alerts as it is depreciated * Remove dashicon usage in shipping label * Fix up old css for icons * Removed dashicon usage in favorite button * Update the wordpress/icons package * Add changelogs * Fix broken test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3613
As suggested in #3613, this PR removes the use of Dashicons anywhere within wcAdmin and makes use of the
@wordpress/iconsorgridicons, as they are tree-shakeable.This does actually make our bundle size a little bit bigger, as the icons are individually imported, and we used
window.wp.componentsfor dashicons.*Note: I currently can't seem to get the wordpress/icons tree shaking to work, and it is pulling in the entire library.It seems all good now.
cc'ing @senadir & @samueljseay incase either of you know what I am missing, this is what a quick gif of the package compiled into the
app/index.js.Screenshots
Detailed test instructions:
true ||for testing purposes here