Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Advanced Filters: Add DatePicker #1146

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Advanced Filters: Add DatePicker #1146

merged 1 commit into from
Jan 14, 2019

Conversation

psealock
Copy link
Collaborator

@psealock psealock commented Dec 21, 2018 •
edited
Loading

Fixes #1027

Add Date Advanced Filter for Customers Report

Accessibility

Due to underlying Gutenberg issues dealing with focus currently being resolved, I'm punting on testing a11y on this component until those get fixes are in place. Issue to track #1145

Screenshots

screen shot 2018-12-21 at 3 42 22 pm

Test

  1. Customers Report, /wp-admin/admin.php?page=wc-admin#/analytics/customers
  2. Show > Advanced Filters > Add a Filter > Registered.
  3. Add, remove, edit dates for before, after, between.
  4. Refresh the page, change the filter.
  5. Make sure the url changes accordingly.

Known Issues

@psealock psealock self-assigned this Dec 21, 2018
@probot-autolabeler probot-autolabeler bot added focus: components Issues for woocommerce components Packages labels Dec 21, 2018
@psealock psealock changed the title Add calendar to date advanced filter Advanced Filters: Add DatePicker Dec 21, 2018
@psealock psealock requested a review from a team January 1, 2019 01:23
jeffstieler
jeffstieler reviewed Jan 5, 2019
View reviewed changes
Copy link
Contributor

@jeffstieler jeffstieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Let's get the screen reader / legend text issue sorted and 🚢 it.

@psealock
Copy link
Collaborator Author

@jeffstieler Could you take another look? I followed the pattern set in #1099 for the screen reader text.

jeffstieler
jeffstieler approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@jeffstieler jeffstieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and tests well. :shipit:

@psealock psealock merged commit 4f69ef4 into master Jan 14, 2019
@psealock psealock deleted the add/date-filter-calendar branch January 14, 2019 20:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffstieler jeffstieler jeffstieler approved these changes

Assignees

@psealock psealock

Labels
focus: components Issues for woocommerce components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Advanced Filter: Date
2 participants
@psealock @jeffstieler