Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop up confirmation prompt on the Shipping page before saving changes #2756

Merged

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

Project thread: pcTzPl-2Cf-p2

This PR implements the 📌 Add popup when saving task of the project.

💡 Update for src/Tracking/README.md will be done by the conjunction PR for the feature branch.

Screenshots:

Kapture.2025-01-09.at.17.47.14.mp4

Detailed test instructions:

  1. Go to step 2 of the onboarding flow
    • Check if clicking the "Continue" button can go to the next step without confirmation prompt
  2. Go to the Shipping page
    • Check if clicking the "Save changes" button can pop up confirmation prompt
    • Click the "Don't save" button to see if it dismisses the save
    • Click the "Save changes" button to pop up confirmation prompt again
    • Click the "Continue to save" button to see if it continues saving
  3. View the E2E testing result: https://github.com/woocommerce/google-listings-and-ads/actions/runs/12687425268

Changelog entry

Tweak - Pop up confirmation prompt on the Shipping page before saving changes.

@eason9487 eason9487 requested a review from a team January 9, 2025 10:03
@eason9487 eason9487 self-assigned this Jan 9, 2025
@github-actions github-actions bot added the changelog: tweak Small change, that isn't actually very important. label Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.7%. Comparing base (6a2b8e4) to head (c530806).
Report is 5 commits behind head on feature/shipping-improvements.

Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                         @@
##             feature/shipping-improvements   #2756      +/-   ##
==================================================================
- Coverage                             67.0%   66.7%    -0.3%     
==================================================================
  Files                                  796     316     -480     
  Lines                                24522    4922   -19600     
  Branches                              1204    1204              
==================================================================
- Hits                                 16423    3282   -13141     
+ Misses                                7962    1503    -6459     
  Partials                               137     137              
Flag Coverage Δ
js-unit-tests 66.7% <ø> (ø)
php-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 480 files with indirect coverage changes

@eason9487 eason9487 mentioned this pull request Jan 9, 2025
1 task
Copy link
Contributor

@puntope puntope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

The modal works as expected. Thanks

@eason9487 eason9487 merged commit e2684ff into feature/shipping-improvements Jan 13, 2025
10 checks passed
@eason9487 eason9487 deleted the tweak/confirmation-before-saving branch January 13, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants