-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace WooCommerce logo to Woo 2.0 Brand #2711
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2711 +/- ##
============================================
- Coverage 67.2% 66.7% -0.5%
============================================
Files 480 316 -164
Lines 19569 4922 -14647
Branches 0 1204 +1204
============================================
- Hits 13155 3282 -9873
+ Misses 6414 1503 -4911
- Partials 0 137 +137
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for changing the Woo logo. Confirmed the new logo were displayed correctly, and I didn't see other places have Woo logo that required to change.
653909b
to
a64faa1
Compare
a64faa1
to
727bf3a
Compare
Feedback: - Increase WooCommerce logo size by 25%. - Decrease Google logo size by 20%. - Align the baseline of logos. - Center the entire grouping (including Google logo and the separator) so that the space on the left and right of the grouping is the same. - The separator won't be in the middle after the adjustment.
727bf3a
to
e93c658
Compare
Changes proposed in this Pull Request:
PT: peeuvX-1Wl-p2
This PR replaces WooCommerce logo to Woo 2.0 Brand.
📌 Checklist before merging (@eason9487)
Screenshots:
📷 Get Started page
Before v.s. After
📷 Submission success modal on Product Feed page
Before v.s. After
Detailed test instructions:
/wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fproduct-feed&guide=submission-success
and view the WooCommerce logo in Submission success modalChangelog entry