Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace WooCommerce logo to Woo 2.0 Brand #2711

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

eason9487
Copy link
Member

@eason9487 eason9487 commented Dec 4, 2024

Changes proposed in this Pull Request:

PT: peeuvX-1Wl-p2

This PR replaces WooCommerce logo to Woo 2.0 Brand.

📌 Checklist before merging (@eason9487)

  • Confirm the official launch date in PT peeuvX-1Wl-p2 or paqDfi-bqN-p2
    • The official launch date is February 4, 2025
  • The changes has been reviewed and approved by the product team
    • They will process this on a staging site and update the statutes on their worksheets
  • Wait until the official launch date is near
    • Can be merged between January 30 and February 3

Screenshots:

📷 Get Started page

Before v.s. After

1

📷 Submission success modal on Product Feed page

Before v.s. After

2

Detailed test instructions:

  1. Go to Get Started page and view the Woo logo in the third card
  2. Go to Product Feed page with path /wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fproduct-feed&guide=submission-success and view the WooCommerce logo in Submission success modal

Changelog entry

Tweak - Replace WooCommerce logo to Woo 2.0 Brand.

@eason9487 eason9487 added the status: on hold The issue is currently not prioritized. label Dec 4, 2024
@eason9487 eason9487 requested a review from a team December 4, 2024 10:14
@eason9487 eason9487 self-assigned this Dec 4, 2024
@github-actions github-actions bot added the changelog: tweak Small change, that isn't actually very important. label Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.7%. Comparing base (6e15a75) to head (e93c658).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2711      +/-   ##
============================================
- Coverage       67.2%   66.7%    -0.5%     
============================================
  Files            480     316     -164     
  Lines          19569    4922   -14647     
  Branches           0    1204    +1204     
============================================
- Hits           13155    3282    -9873     
+ Misses          6414    1503    -4911     
- Partials           0     137     +137     
Flag Coverage Δ
js-unit-tests 66.7% <ø> (?)
php-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ges/product-feed/submission-success-guide/index.js 65.2% <ø> (ø)

... and 795 files with indirect coverage changes

Copy link
Member

@ianlin ianlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing the Woo logo. Confirmed the new logo were displayed correctly, and I didn't see other places have Woo logo that required to change.

Feedback:
- Increase WooCommerce logo size by 25%.
- Decrease Google logo size by 20%.
- Align the baseline of logos.
- Center the entire grouping (including Google logo and the separator)
  so that the space on the left and right of the grouping is the same.
- The separator won't be in the middle after the adjustment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: tweak Small change, that isn't actually very important. status: on hold The issue is currently not prioritized.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants