Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use scheduled_date when passed for recurring actions #294

Merged
merged 1 commit into from
Apr 24, 2019
Merged

use scheduled_date when passed for recurring actions #294

merged 1 commit into from
Apr 24, 2019

Conversation

rrennick
Copy link
Contributor

Fixes #293

This PR updates the post store save_action function to use the $scheduled_date parameter for scheduling the next instance of the scheduled action.

Testing instructions

  • Follow the steps to reproduce the issue outlined in the issue
  • The new scheduled action should be scheduled for a recurrence period into the future instead of Now.

@rrennick rrennick requested a review from JPry April 23, 2019 19:37
@rrennick rrennick mentioned this pull request Apr 23, 2019
Closed
@rrennick rrennick merged commit 0d1c8fc into master Apr 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/293 branch April 24, 2019 12:38
This was referenced Jul 11, 2019
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikejolley mikejolley mikejolley approved these changes

@JPry JPry JPry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running recurring action scheduled in the past is rescheduled for Now
3 participants
@rrennick @mikejolley @JPry