Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduction of the MULTIHOME parameter #384

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Chaos02
Copy link

@Chaos02 Chaos02 commented Dec 14, 2024

Reintroduction of the Multihome parameter for better compatibility with complex networks.

Seemingly allows better operation on IPv6 only networks

Caused by:
#301

@wolveix
Copy link
Owner

wolveix commented Dec 16, 2024

Hey @Chaos02, thanks for the contribution! I've adjusted your repo to fit the consistency of the rest of the repo (e.g. alphabetised order for environment variables in the README, logical ordering of variable handling in run.sh, etc.

Unfortunately, your IPv6 regex doesn't support shorthand values (e.g. 2041:0000:140F::875B:131B). Personally, I would omit IP validation, but I'll leave the ball in your court on that one! I haven't tested your changes in v4-only and v6-only environments yet, but I'm assuming you have? :)

@Chaos02
Copy link
Author

Chaos02 commented Dec 17, 2024

Thanks a lot!
I've tried to sort by relation / purpose, didn't notice that it's alphabetical...
I implemented the valid-ness of IPs since it's kind of a hassle if you give the server invalid Syntax (it crashes ungracefully and you have to dig the log).
Totally forgot about the shorthand, will absolutely add.
Tested in V6 only, yes.
Currently don't have v4 only but I'll just try forcing v4

@wolveix wolveix marked this pull request as draft December 18, 2024 12:01
Copy link
Author

@Chaos02 Chaos02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed IPv6 validation - the regex lets through some edge cases but I added a double check using the PING command, since it not only validates but also checks if the interface exists.
At your choice wether to use just PING as the sole validator.

Will test after the holidays, no access to test environment

@Chaos02 Chaos02 marked this pull request as ready for review December 22, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants