Skip to content

Commit

Permalink
Disable SmallestUnCommittedSeq in Valgrind run (facebook#6035)
Browse files Browse the repository at this point in the history
Summary:
SmallestUnCommittedSeq sometimes takes too long when run under Valgrind. The patch disables it when the tests are run under Valgrind.
Pull Request resolved: facebook#6035

Differential Revision: D18509198

Pulled By: maysamyabandeh

fbshipit-source-id: 1191443b9fedb6b9c50d6b76f5c92371f5030230
  • Loading branch information
Maysam Yabandeh authored and facebook-github-bot committed Nov 14, 2019
1 parent a7cab59 commit 0d05cf5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions utilities/transactions/write_prepared_transaction_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1578,6 +1578,7 @@ TEST_P(WritePreparedTransactionTest, AdvanceMaxEvictedSeqWithDuplicatesTest) {
delete txn0;
}

#ifndef ROCKSDB_VALGRIND_RUN
// Stress SmallestUnCommittedSeq, which reads from both prepared_txns_ and
// delayed_prepared_, when is run concurrently with advancing max_evicted_seq,
// which moves prepared txns from prepared_txns_ to delayed_prepared_.
Expand Down Expand Up @@ -1639,6 +1640,7 @@ TEST_P(WritePreparedTransactionTest, SmallestUnCommittedSeq) {
delete txn;
}
}
#endif // ROCKSDB_VALGRIND_RUN

TEST_P(SeqAdvanceConcurrentTest, SeqAdvanceConcurrentTest) {
// Given the sequential run of txns, with this timeout we should never see a
Expand Down

0 comments on commit 0d05cf5

Please sign in to comment.