Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re2: improve packaging quality #4734

Merged
merged 1 commit into from
Aug 23, 2023
Merged

re2: improve packaging quality #4734

merged 1 commit into from
Aug 23, 2023

Conversation

kaniini
Copy link
Contributor

@kaniini kaniini commented Aug 23, 2023 •
edited
Loading

  • use cmake pipelines instead of runs statements
  • remove irrelevant data block copied from mesa
  • remove variable expansion for -DRE2_BUILD_TESTING cmake option

Fixes #4580.

@kaniini
re2: improve packaging quality
ebb80f7 
- use cmake pipelines instead of runs statements
- remove irrelevant data block copied from mesa
- remove variable expansion for -DRE2_BUILD_TESTING cmake option

Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
@kaniini kaniini requested a review from a team as a code owner August 23, 2023 15:56
@kaniini kaniini requested review from imjasonh and jdolitsky August 23, 2023 15:56
@github-actions
Copy link
Contributor

Package re2: Click to expand/collapse

Package re2:
Added: /usr/lib/libre2.so.11.0.0
Deleted: /usr/lib64/cmake/re2/re2Config.cmake
Deleted: /usr/lib64/cmake/re2/re2ConfigVersion.cmake
Deleted: /usr/lib64/cmake/re2/re2Targets-none.cmake
Deleted: /usr/lib64/cmake/re2/re2Targets.cmake
Deleted: /usr/lib64/libre2.so.11.0.0
Deleted: /usr/lib64/pkgconfig/re2.pc

Package re2-dev: Click to expand/collapse

Package re2-dev:
Added: /usr/lib/cmake/re2/re2Config.cmake
Added: /usr/lib/cmake/re2/re2ConfigVersion.cmake
Added: /usr/lib/cmake/re2/re2Targets-minsizerel.cmake
Added: /usr/lib/cmake/re2/re2Targets.cmake
Added: /usr/lib/pkgconfig/re2.pc

@kaniini kaniini added this pull request to the merge queue Aug 23, 2023
Merged via the queue into main with commit 3ccaf17 Aug 23, 2023
@kaniini kaniini deleted the fix/re2-quality branch August 23, 2023 16:20
@philroche philroche mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developer-guy developer-guy developer-guy approved these changes

@imjasonh imjasonh Awaiting requested review from imjasonh imjasonh was automatically assigned from wolfi-dev/wolfi-repository-maintainers

@jdolitsky jdolitsky Awaiting requested review from jdolitsky jdolitsky was automatically assigned from wolfi-dev/wolfi-repository-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaniini @developer-guy