Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name VS2022 binary output wolfssl via project name #8104

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

gojimmypi
Copy link
Contributor

Description

This is a no-code-change PR that updates the project name of the new VS 2022 project files introduced in #8090.

Currently the output binary name would be wolfssl-VS2022.lib and/or wolfssl-VS2022.dll.

The new name will be wolfssl.lib and/or wolfssl.dll.

For instance, when compiling the benchmark example, note the new output file when compiling the wolfssl project is instead wolfssl.lib with this PR.

1>Generating Code...
1>wolfssl-VS2022.vcxproj -> C:\workspace\wolfssl-gojimmypi-pr\wolfcrypt\benchmark\Debug\x64\wolfssl.lib
2>------ Rebuild All started: Project: benchmark-VS2022, Configuration: Debug x64 ------
2>benchmark.c
2>benchmark-VS2022.vcxproj -> C:\workspace\wolfssl-gojimmypi-pr\wolfcrypt\benchmark\x64\Debug\benchmark-VS2022.exe
========== Rebuild All: 2 succeeded, 0 failed, 0 skipped ==========
========== Rebuild completed at 9:33 AM and took 07.492 seconds ==========

Fixes zd# n/a

Testing

Tested on Windows 11, Visual Studio 2022

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@gojimmypi
Copy link
Contributor Author

Jenkins retest this please

@JacobBarthelmeh JacobBarthelmeh merged commit 1d25e0f into wolfSSL:master Oct 23, 2024
141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants