Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for invalid hash requirements. #8102

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

embhorn
Copy link
Member

@embhorn embhorn commented Oct 23, 2024

Description

Fixes documentation inconsistency reported in forum post:
https://www.wolfssl.com/forums/topic2203-why-do-we-have-to-use-shake256-with-ed25519-and-ed448.html

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@embhorn embhorn self-assigned this Oct 23, 2024
@embhorn
Copy link
Member Author

embhorn commented Oct 23, 2024

retest this please

@embhorn embhorn assigned wolfSSL-Bot and unassigned embhorn Oct 23, 2024
Copy link
Contributor

@SparkiDev SparkiDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a copy past error from Ed448.
Must be SHA-512 for Ed25519 and SHAKE-256 for Ed448 by FIPS 186-5.
Doesn't need to be these hashes if not FIPS.

@dgarske dgarske merged commit fc56060 into wolfSSL:master Oct 30, 2024
141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants