Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Codespell test to PRs #8043

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Add Codespell test to PRs #8043

wants to merge 23 commits into from
+198 −150

Conversation

bandi13
Copy link
Contributor

@bandi13 bandi13 commented Oct 4, 2024

Adding in a spell checker

@bandi13 bandi13 self-assigned this Oct 4, 2024
@bandi13 bandi13 force-pushed the addCodespell branch 9 times, most recently from 3e9a8e1 to 4093930 Compare October 7, 2024 14:00
@bandi13 bandi13 assigned wolfSSL-Bot and unassigned bandi13 Oct 7, 2024
@bandi13 bandi13 requested a review from philljj October 7, 2024 15:04
philljj
philljj requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@philljj philljj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicky requests/suggestions:

  1. We should skip files that throw codespell utf-8 warnings: .csv, .der, any Japanese translation txt files, etc.

  2. Recommend merge squashing this to 1 commit.

  3. Should we restrict this to code comments only for now? E.g. start with small experimental introduction of automated codespell.

.github/workflows/coverity-scan-fixes.yml Outdated Show resolved Hide resolved
.github/workflows/codespell.yml Outdated Show resolved Hide resolved
@bandi13 bandi13 assigned bandi13 and unassigned wolfSSL-Bot Oct 8, 2024
@bandi13 bandi13 requested a review from philljj October 8, 2024 12:56
@bandi13 bandi13 assigned wolfSSL-Bot and unassigned bandi13 Oct 8, 2024
douzzer
douzzer requested changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@douzzer douzzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alas we (I) merged a PR with a spelling error in it:

Error: ./wrapper/CSharp/wolfSSL_CSharp/wolfCrypt.cs:1633: Clenup ==> Cleanup

the sooner we get this PR merged, the better!

@douzzer douzzer assigned bandi13 and unassigned wolfSSL-Bot Oct 8, 2024
@bandi13 bandi13 assigned wolfSSL-Bot and unassigned bandi13 Oct 9, 2024
@bandi13 bandi13 requested a review from douzzer October 9, 2024 01:07
@gojimmypi gojimmypi mentioned this pull request Oct 9, 2024
Closed
4 tasks
@bandi13 bandi13 force-pushed the addCodespell branch 2 times, most recently from 9889ebe to 1e140a7 Compare October 21, 2024 19:18
dgarske
dgarske requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

IDE/Renesas/e2studio/RX72N/EnvisionKit/Simple/test/test.scfg Outdated
@@ -722,125 +722,125 @@
<allocatable id="TMR0">
<isocket id="CountingClock" selection="Clock.tool_clock_pclkb" value="6.0E7"/>
<option enabled="true" id="CountMode" selection="8bitMode">
<item id="8bitMode" input="" vlaue="0"/>
<item id="16bitMode" input="" vlaue="0"/>
<item id="8bitMode" input="" value="0"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure you can/should fix these. This is a property for a code generation tool. Prefer you just add an exception for these files.

IDE/Renesas/e2studio/RX65N/GR-ROSE/smc/smc.scfg Outdated
@@ -564,125 +564,125 @@
<allocatable id="TMR0">
<isocket id="CountingClock" selection="Clock.tool_clock_pclkb" value="3.0E7"/>
<option enabled="true" id="CountMode" selection="8bitMode">
<item id="8bitMode" input="" vlaue="0"/>
<item id="16bitMode" input="" vlaue="0"/>
<item id="8bitMode" input="" value="0"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure you can/should fix these. This is a property for a code generation tool. Prefer you just add an exception for these files.

Andras Fekete added 23 commits November 1, 2024 12:59
Add Codespell test to PRs
19e9e31
Use ignore words list instead of file
725e432
Minor fixes
57acf72
Fix some spelling
631eafa
Spellcheck on assembly
97998d0
Few more exceptions
88d4b4c
Spelling fixes
b3fe71d
More exceptions
6c4b403
More spelling fixes
8ecfe31
Final set of spelling fixes
b8253ac
Fix multiple filenames
099c6e0
Simple word fix
8b81d6e
Suspicious that codespell is not checking spelling
c0cb206
Few more spelling mistakes
f4dae7c
Add in some common code to keep Actions to a minimum
31d0dfb
Eliminate some UTF-8 errors
b8f9ac6
Add explanations for excluded files
552968b
Cleaner way to exclude words that are considered 'misspelled'
e283160
Change the name of the file.
9082baa
Cleanup spelling
e14abbd
More spelling fixes
34298e8
Don't modify Renesas config files
8612f15
Fix new spelling errors
0915012
@dgarske
Copy link
Contributor

dgarske commented Nov 1, 2024

Retest this please:

PRB-known-configs.txt_70': FAIL: scripts/external
wolfSSL error: tcp connect failed: Connection timed out

@bandi13 bandi13 removed their assignment Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embhorn embhorn embhorn left review comments

@dgarske dgarske dgarske approved these changes

@philljj philljj philljj approved these changes

@douzzer douzzer Awaiting requested review from douzzer

Requested changes must be addressed to merge this pull request.

Assignees

@wolfSSL-Bot wolfSSL-Bot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bandi13 @dgarske @douzzer @embhorn @philljj @wolfSSL-Bot