-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
20240511-aes-xts-stream #7522
20240511-aes-xts-stream #7522
Conversation
bebc80b
to
15b710e
Compare
15b710e
to
e98c95b
Compare
retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are the tests for WOLFSSL_AESXTS_STREAM
? I see init, update, but not final. What API's are used for that?
Please update the PR description. Seems outdated... |
Disregard the final. I see the update does it inline. I see it called in lkcapi_glue.c, but I really want to see a wolfCrypt test added for AES XTS stream before we can merge this. |
retest this please |
…art(), wc_AesXtsDecryptStart(), wc_AesXtsEncryptUpdate(), wc_AesXtsDecryptUpdate(), and implement fixes in linuxkm/lkcapi_glue.c to use the streaming API when needed. also added support for 2*192 bit AES-XTS, needed for Linux kernel.
…except for the known-good --enable-linuxkm-lkcapi-register="xts(aes)".
…,decrypt}_{start,update}_{avx1,aesni}.
…ock. instead, caller-supplied iv is used as a readwrite buffer.
Changed APIs from wc_AesXts*Start -> wc_AesXts*Init. Enabled ASM for x64 in aes.c. AesXtsDecryptStart_sw same as AesXtsEncryptStart_sw so changed them to AesXtsInit_sw.
wolfcrypt/src/aes.c: activate _AesXtsHelper() in AesXts{En,De}cryptUpdate_sw().
…AesXts{En,De}cryptUpdate_sw().
linuxkm/lkcapi_glue.c: typographic cleanups, and failsafe error return constructs when skcipher_walk_virt() returns zero walk.nbytes. wolfcrypt/src/aes.c: additional comments and inline documentation. .github/workflows/openvpn.yml: disable test on master branch.
6f22e6b
to
e89e967
Compare
e89e967
to
4331bc0
Compare
retest this please |
…REAM. wolfcrypt/test/test.c: * add WOLFSSL_AESXTS_STREAM testing to the LARGE_XTS_SZ exercise in aes_xts_128_test(). * add the LARGE_XTS_SZ exercise to aes_xts_256_test(). * add aes_xts_192_test(). * fix -Werror=frame-larger-than=2048 in ed25519_test().
4562ffd
to
1469aab
Compare
20240511-aes-xts-stream
add
WOLFSSL_AESXTS_STREAM
,--enable-aesxts-stream
,wc_AesXtsEncryptInit()
,wc_AesXtsDecryptInit()
,wc_AesXtsEncryptUpdate()
,wc_AesXtsDecryptUpdate()
, and implement fixes inlinuxkm/lkcapi_glue.c
to use the streaming API when needed. also added support for 2*192 bit AES-XTS, needed for Linux kernel.tested with
wolfssl-multi-test.sh ... linuxkm-aesxts-cryptonly-aesni-LKCAPI-no-twc-insmod-6.1.73-fortify linuxkm-aesxts-cryptonly-noasm-LKCAPI-no-twc-insmod-6.1.73-fortify super-quick-check
, with a6.1.73-fortify
kernel withCONFIG_CRYPTO_MANAGER_DISABLE_TESTS
unset andCONFIG_CRYPTO_MANAGER_EXTRA_TESTS
set.note, the Linux kernel crypto test harness tests the new APIs extensively, including fuzz testing.