Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When comparing subject names, do not worry about case. #7420

Merged
merged 1 commit into from
May 15, 2024

Conversation

anhu
Copy link
Member

@anhu anhu commented Apr 12, 2024

Fixes #7414

Testing

Added a test case.

@anhu
Copy link
Member Author

anhu commented Apr 12, 2024

jenkins retest this please.

@anhu anhu force-pushed the cmp_name_case branch 2 times, most recently from 478a45e to 9f5c040 Compare May 3, 2024 17:18
@anhu anhu assigned wolfSSL-Bot and unassigned anhu May 15, 2024
@dgarske
Copy link
Contributor

dgarske commented May 15, 2024

@SparkiDev please confirm X509_NAME_cmp should use case insensitive compare. I agree with reporter that this should be case insensitive.

@SparkiDev
Copy link
Contributor

I agree.
OpenSSL converts to all ASCII to lowercase when canonicalising for comparison.

@SparkiDev SparkiDev merged commit abd1e36 into wolfSSL:master May 15, 2024
114 checks passed
jefferyq2 pushed a commit to jefferyq2/wolfssl that referenced this pull request Jun 9, 2024
When comparing subject names, do not worry about case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: X509_NAME_cmp returns != 0 for subject names that only differ in capitalization
4 participants