-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MSYS2 build CI test #6932
base: master
Are you sure you want to change the base?
Add MSYS2 build CI test #6932
Conversation
ff0c553
to
67b75f1
Compare
f0692ab
to
246438b
Compare
@@ -7457,7 +7463,7 @@ static THREAD_RETURN WOLFSSL_THREAD test_server_nofail(void* args) | |||
static THREAD_RETURN WOLFSSL_THREAD test_server_loop(void* args) | |||
{ | |||
SOCKET_T sockfd; | |||
SOCKET_T clientfd = -1; | |||
SOCKET_T clientfd; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually we use SOCKET_INVALID
.
@@ -581,6 +581,12 @@ static int testDevId = INVALID_DEVID; | |||
#define HAVE_SSL_MEMIO_TESTS_DEPENDENCIES | |||
#endif | |||
|
|||
#ifdef USE_WINDOWS_API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems unnecessary. Either case should be happy with (char*)
@@ -7472,6 +7478,7 @@ static THREAD_RETURN WOLFSSL_THREAD test_server_loop(void* args) | |||
func_args* opts = (func_args*)args; | |||
int loop_count = opts->argc; | |||
int count = 0; | |||
int freeClientfd = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be required.
@@ -7638,7 +7646,7 @@ static THREAD_RETURN WOLFSSL_THREAD test_server_loop(void* args) | |||
if (!sharedCtx) | |||
wolfSSL_CTX_free(ctx); | |||
|
|||
if (clientfd >= 0) | |||
if (freeClientfd) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clientFd != SOCKET_INVALID
Description
Add MSYS2 build CI github actions test
Checklist