Fix static analyzer possible leak #6894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crl would never be null there but clean up code to make sure newcrl->crlLock gets free'd
|
Retest this please |
bandi13
reviewed
Oct 23, 2023
| ret = DupX509_CRL(crl, newcrl); | ||
| wc_UnLockRwLock(&newcrl->crlLock); | ||
| if (ret != 0) { | ||
| FreeCRL(crl, 1); |
There was a problem hiding this comment.
Do you need to check crl != NULL here like the original code did?
There was a problem hiding this comment.
FreeCRL should also check crl != NULL and return BAD_ARG_ERR or something. It will crash if NULL is passed.
There was a problem hiding this comment.
crl will never be NULL here as its checked right after allocation. I agree that FreeCRL should be performing a check internally though.
bandi13
requested changes
Oct 23, 2023
bandi13
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crl would never be null there but clean up code to make sure newcrl->crlLock gets free'd