ESP32 debug only: Mode REVERT to ESP32_SHA_SW #6811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 26, 2023
|
I've reviewed the Jenkins failure. I don't think this PR is the cause. If it is, I'd like to better understand. |
|
Retest this please. |
JacobBarthelmeh
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses wolfSSL/wolfMQTT#353 by wrapping a single line of code in conditional debug macro. The HW lock is unexpectedly unable to be obtained when using wolfMQTT. The result is a flood of undesired debug messages.
This is related to wolfSSL/wolfMQTT#352, specifically my AWS_IoT_MQTT example.
Fixes zd# n/a
Testing
How did you test?
manual testing
Checklist