Fix benchmark failure on FIPS builds #6623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobBarthelmeh
previously approved these changes
Jul 20, 2023
|
Retest this please |
|
Retest this please |
dgarske
force-pushed
the
FIPS-TLS-benchmark-CAST-fix
branch
from
64df3bb
to
e823da9
Compare
|
Can't seem to get it to re-test or pass this macOS check in GitHub CI. I went ahead and rebased and force pushed. Let's see if we still get a failure. |
dgarske
previously approved these changes
May 17, 2024
SparkiDev
reviewed
May 19, 2024
examples/benchmark/tls_bench.c
Outdated
| int ret = 0; | ||
| int cast_idx = 0; | ||
|
|
||
| for (cast_idx=0; cast_idx<FIPS_CAST_COUNT; cast_idx++) { |
dgarske
approved these changes
May 20, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 9, 2024
…-fix Fix benchmark failure on FIPS builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug where
tls_benchcan fail on FIPS builds in a multithreaded environment because of simultaneous attempts by client and server threads to run a CAST on-the-fly during the TLS handshake. This usually manifests itself as a KAT failure in ECC or AES, though I have seen a few other spurious error messages pop up depending on timing.Bug reproduction
Try and run
tls_benchon a multithreaded system onmasterand it should fail and report a KAT failure. Running on this branch should resolve the issue.