Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no WSL/Windows git hooks from autogen.sh #600

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

gojimmypi
Copy link
Contributor

Similar to wolfSSL/wolfssl#6798 this PR fixes #592 and prevents autogen.sh from copying git hook shell scripts in WSL when the underlying file system is shared with Windows.

The wolfssh autogen.sh is slightly different from the wolfssl version in that only the pre-commit.sh file is used. This PR includes code that is commented out for future use of the pre-push.sh.

@gojimmypi
Copy link
Contributor Author

Hi @ejohnstown

I bumped into this issue again today. Just a minor annoyance if you know the fix (delete the zero-byte files created in .git\hooks by autogen.sh), but not very intuitive for Visual Studio users that may encounter it for the first time. See wolfSSL/wolfssl#6779

I've refreshed from upstream. Let me know if there's anything holding up this merge. Thank you.

@ejohnstown ejohnstown merged commit e6d2eef into wolfSSL:master Jan 12, 2024
10 checks passed
@gojimmypi gojimmypi deleted the autogen-update-wsl-pr2 branch February 16, 2024 19:45
@gojimmypi gojimmypi restored the autogen-update-wsl-pr2 branch February 16, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wolfSSL GitHooks pre-commit: incompatible on Visual Studio Windows WSL
2 participants