Possible patch for POSIX conditional wait issue #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embhorn
reviewed
Oct 2, 2023
| pthread_mutex_lock(&s->mutex); | ||
| s->lockCount--; | ||
| pthread_cond_signal(&s->cond); | ||
| if (s->lockCount > 0) { |
There was a problem hiding this comment.
Should the else case here return an error code?
There was a problem hiding this comment.
We don't handle the wm_SemUnlock return code anywhere in wolfMQTT. However I will run some tests and see if this case ever occurs. I suspect it might and that's okay and should not be considered an error.
There was a problem hiding this comment.
Our test cases aren't triggering it, however I think with the complicated locks in the state machine for lockRecv with the right abort this might be able to occur. Ignoring it is safe "in my opinion".
embhorn
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ZD 16769