Focus handling compatible #565
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wojtekmaj If you don't plan deprecating support for React <16.3 soon as required by #449 it would be cool to merge this one instead. Any thoughts? |
wojtekmaj
force-pushed
the
main
branch
3 times, most recently
from
12b3d6b to
398685c
Compare
wojtekmaj
force-pushed
the
main
branch
3 times, most recently
from
cf41d22 to
8648f43
Compare
wojtekmaj
force-pushed
the
main
branch
6 times, most recently
from
74ca107 to
fca6887
Compare
wojtekmaj
force-pushed
the
main
branch
3 times, most recently
from
0ed5255 to
5a3d1e6
Compare
wojtekmaj
force-pushed
the
main
branch
4 times, most recently
from
cef9c7c to
cd7ef12
Compare
wojtekmaj
force-pushed
the
main
branch
3 times, most recently
from
0f9c665 to
88f5da5
Compare
wojtekmaj
force-pushed
the
main
branch
3 times, most recently
from
1f10b65 to
0c5a8da
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
d6fcc20 to
da505dd
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
3407450 to
7fc3da6
Compare
wojtekmaj
force-pushed
the
main
branch
3 times, most recently
from
9045b27 to
22f61e6
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
dc4fd25 to
a8c5ad5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #449. I tried to focus handling without the need of React hooks.
Created an index class for each navigable tile and then on Calendar.jsx listen for keypresses and handle the focus.
Currently not changing months, years etc on edge tiles and not sure how this would work on disabled ones.
Tested this on sample folder my importing the local build version.
Focus-Handling.mov