Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support any enumerable in mutlipart 2 #457

Merged
merged 5 commits into from
Feb 21, 2025

Conversation

knightpp
Copy link
Contributor

@knightpp knightpp commented Feb 16, 2025

Closes #456

  • adds :content_length (maybe rename to :size?)
  • the new option IS required when value type is Enumerable
  • no validation :( users can craft requests with incorrect content-length header

@knightpp
Copy link
Contributor Author

See previous PR #444

@knightpp knightpp force-pushed the add-multipart-stream branch from a6e44e2 to ff8adfd Compare February 19, 2025 20:52
@knightpp knightpp force-pushed the add-multipart-stream branch from ff8adfd to 5c80de3 Compare February 20, 2025 20:18
@wojtekmach wojtekmach merged commit ba4de2a into wojtekmach:main Feb 21, 2025
2 checks passed
@wojtekmach
Copy link
Owner

I added some minor updates to the PR. Thank you!

@knightpp knightpp deleted the add-multipart-stream branch February 22, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multipart should support streaming bodies 2
2 participants