checksum: Add Req.ChecksumMismatchError

Closes #254
wojtekmach · Nov 29, 2023 · 899bb7e · 899bb7e
1 parent e94d744
commit 899bb7e
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 17 deletions.
diff --git a/lib/req/checksum_mismatch_error.ex b/lib/req/checksum_mismatch_error.ex
@@ -0,0 +1,11 @@
+defmodule Req.ChecksumMismatchError do
+  defexception [:expected, :actual]
+
+  def message(%{expected: expected, actual: actual}) do
+    """
+    checksum mismatch
+    expected: #{expected}
+    actual:   #{actual}\
+    """
+  end
+end
diff --git a/lib/req/steps.ex b/lib/req/steps.ex
@@ -1250,21 +1250,18 @@ defmodule Req.Steps do
            |> :crypto.hash_final()
            |> Base.encode16(case: :lower, padding: false))
 
-      if expected != actual do
-        raise """
-        checksum mismatch
-        expected: #{expected}
-        actual:   #{actual}\
-        """
-      end
-
-      request =
-        update_in(
-          request.private,
-          &Map.drop(&1, [:req_checksum_hash, :req_checksum_expected, :req_checksum_type])
-        )
+      if expected == actual do
+        request =
+          update_in(
+            request.private,
+            &Map.drop(&1, [:req_checksum_hash, :req_checksum_expected, :req_checksum_type])
+          )
 
-      {request, response}
+        {request, response}
+      else
+        exception = Req.ChecksumMismatchError.exception(expected: expected, actual: actual)
+        {request, exception}
+      end
     else
       {request, response}
     end

diff --git a/test/req/steps_test.exs b/test/req/steps_test.exs
@@ -293,7 +293,7 @@ defmodule Req.StepsTest do
       resp = Req.get!(req, checksum: @foo_sha256)
       assert resp.body == "foo"
 
-      assert_raise RuntimeError,
+      assert_raise Req.ChecksumMismatchError,
                    """
                    checksum mismatch
                    expected: sha1:bad
@@ -323,7 +323,7 @@ defmodule Req.StepsTest do
       resp = Req.get!(req, checksum: @foo_sha256)
       assert resp.body == "foo"
 
-      assert_raise RuntimeError,
+      assert_raise Req.ChecksumMismatchError,
                    """
                    checksum mismatch
                    expected: sha1:bad
@@ -351,7 +351,7 @@ defmodule Req.StepsTest do
       resp = Req.get!(req, checksum: @foo_sha256)
       assert resp.body == ["foo"]
 
-      assert_raise RuntimeError,
+      assert_raise Req.ChecksumMismatchError,
                    """
                    checksum mismatch
                    expected: sha1:bad