Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing build-system #164

Merged
merged 2 commits into from
Apr 28, 2024
Merged

Conversation

branchvincent
Copy link
Contributor

This causes missing metadata for source builds (since build-system will default to setuptools which won't pickup the metadata from poetry)

$ pip install --no-binary=:all: decli
Collecting decli
  Downloading decli-0.6.1.tar.gz (7.4 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
  Preparing metadata (pyproject.toml) ... done
Discarding https://files.pythonhosted.org/packages/2e/9c/b76485e6120795c8b632707bafb4a9a4a2b75584ca5277e3e175c5d02225/decli-0.6.1.tar.gz (from https://pypi.org/simple/decli/) (requires-python:>=3.7): Requested decli from https://files.pythonhosted.org/packages/2e/9c/b76485e6120795c8b632707bafb4a9a4a2b75584ca5277e3e175c5d02225/decli-0.6.1.tar.gz has inconsistent version: expected '0.6.1', but metadata has '0.0.0'

@woile
Copy link
Owner

woile commented Apr 28, 2024

Thanks for the PR! Can you try removing 3.7 from the CI?
https://github.com/woile/decli/blob/master/.github/workflows/test.yaml#L15

@branchvincent
Copy link
Contributor Author

@woile no prob, removed

@woile woile merged commit a4480b9 into woile:master Apr 28, 2024
0 of 4 checks passed
@branchvincent branchvincent deleted the build-system branch April 28, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants