Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for NOXPYTHON, NOXEXTRAPYTHON and NOXFORCEPYTHON #688

Merged
merged 7 commits into from
Feb 15, 2023
Merged

Add support for NOXPYTHON, NOXEXTRAPYTHON and NOXFORCEPYTHON #688

merged 7 commits into from
Feb 15, 2023

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Jan 27, 2023 •
edited
Loading

Closes #672

@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 30, 2023 07:05
@edgarrmondragon edgarrmondragon mentioned this pull request Feb 1, 2023
Closed
DiddiLeija
DiddiLeija reviewed Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from my side!

.pre-commit-config.yaml Outdated Show resolved Hide resolved
FollowTheProcess
FollowTheProcess requested changes Feb 11, 2023
View reviewed changes
Copy link
Collaborator

@FollowTheProcess FollowTheProcess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a small nit around a docstring. Love the sphinx tabs by the way they look great!

nox/_options.py Outdated Show resolved Hide resolved
@FollowTheProcess FollowTheProcess self-requested a review February 12, 2023 13:53
FollowTheProcess
FollowTheProcess approved these changes Feb 12, 2023
View reviewed changes
Copy link
Collaborator

@FollowTheProcess FollowTheProcess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, LGTM

DiddiLeija
DiddiLeija approved these changes Feb 12, 2023
View reviewed changes
Copy link
Collaborator

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @edgarrmondragon!

@edgarrmondragon
Copy link
Contributor Author

I think all the feedback's been addressed. Feel free to merge 😄

@FollowTheProcess FollowTheProcess merged commit 593017f into wntrblm:main Feb 15, 2023
@bmritz bmritz mentioned this pull request Apr 25, 2023
Merged
@edgarrmondragon edgarrmondragon deleted the feat/python-env-vars branch May 15, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii left review comments

@DiddiLeija DiddiLeija DiddiLeija approved these changes

@FollowTheProcess FollowTheProcess FollowTheProcess approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support a NOXPYTHON environment variable similar to NOXSESSION
4 participants
@edgarrmondragon @henryiii @FollowTheProcess @DiddiLeija