Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move to 3.11 final #667

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Conversation

henryiii
Copy link
Collaborator

This moves to using Python 3.11 final on GHA as well as uses it by default for the action.

While doing this, I noticed we are using the deprecated set-output string. I'll try to make a followup that fixes this.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii marked this pull request as ready for review October 27, 2022 13:42
@henryiii
Copy link
Collaborator Author

I'll try to make a followup that fixes this.

Looks like #668 beat me to it. That's fine :) I'm happy to rebase if you want to put that one in first.

Copy link
Collaborator

@FollowTheProcess FollowTheProcess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending a question about the GHA workflow 👍🏻

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting for #667 (comment), once that gets done LGTM!

@FollowTheProcess
Copy link
Collaborator

Nice! Thanks @henryiii 🎉

@FollowTheProcess FollowTheProcess merged commit 3fad6a5 into wntrblm:main Oct 31, 2022
@henryiii henryiii deleted the henryiii/chore/311 branch October 31, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants