Add short -N alias for --no-reuse-existing-virtualenvs

[johnthagen]

Closes #624

[johnthagen]

$ python nox --help
...
  -nr, --no-reuse-existing-virtualenvs
                        Disables --reuse-existing-virtualenvs if it is enabled in the Noxfile.

[johnthagen]

@DiddiLeija @crwilcox @ktbarrett Could you review?

Specifically, are we sure we want to set a precedent of using a multi-letter short option (-nr) vs picking another single letter short option (such as -C)?

[ktbarrett]

Looks fine to me, but I'm no maintainer.

are we sure we want to set a precedent of using a multi-letter short option

The precedent is already set by a number of other options. Scrolling up a few lines shows -fb, -db, and a couple others.

[johnthagen]

The precedent is already set by a number of other options. Scrolling up a few lines shows -fb, -db, and a couple others.

That is a good point and something I missed.

[FollowTheProcess]

Is -N available? That might be better than -nr?

[johnthagen]

It appears that -N is available. I'm happy to change to that if that is the consensus of the Nox team.

[DiddiLeija]

No objections from me :)

[FollowTheProcess]

It appears that -N is available. I'm happy to change to that if that is the consensus of the Nox team.

I'm easy either way really it's not a dealbreaker. I just don't like the look of "short" options with more than 1 character (I know we already have some) We have a precedent for capitals with -R for reuse and no install (from memory) so -N would fit better IMO

[johnthagen]

Sounds good. I've changed to -N. I also prefer this way.

When merging, if someone could hit the "Squash" button in the GitHub UI, I'd appreciate it.

[FollowTheProcess]

When merging, if someone could hit the "Squash" button in the GitHub UI, I'd appreciate it.

We only allow squashes anyway 👍🏻

[FollowTheProcess]

LGTM, nice job thanks!